Default to ring if multiple rustls features are set#183
Merged
ValuedMammal merged 3 commits intobitcoindevkit:masterfrom Nov 3, 2025
Merged
Conversation
We assert that we still succeed compilation if multiple `rustls` features are set.
This was referenced Nov 3, 2025
Contributor
Author
|
CI failure seems unrelated: #184. |
Contributor
|
ACK 0e28021. I'll see about adding a commit ValuedMammal/rust-electrum-client@7664faf to fix CI before merging. |
Changed `test_relay_fee` to no longer assert the value of min relay fee, and instead assert that the value is non-zero. This fixes a test failure likely due to some nodes now having a smaller default min relay fee (100sat).
Contributor
|
ACK 80bf744. |
ValuedMammal
approved these changes
Nov 3, 2025
radiant-smith-lk20
added a commit
to radiant-smith-lk20/rust-electrum-client
that referenced
this pull request
Dec 15, 2025
…ltiple `rustls` features are set
80bf744a706caf60f08a97cf49f02531239715cd test: don't assert the value returned by `relay_fee` (valued mammal)
0e28021b3e5f16a792d2eeb3864333c8e762d784 Check in CI that we compile if all `rustls` features are set (Elias Rohrer)
980fa4afd69e8a3700958d28ce99780369e10313 Default to `ring` if multiple `rustls` features are set (Elias Rohrer)
Pull request description:
Fixes #181
We default to use `ring` if multiple features are set, ensuring the features are additive. To that end, we also add a check to CI that asserts we succeed to build with both features set.
Would be cool to get a patch release for this, as it's currently breaking our docs.rs builds in `lightning-liquidity`.
ACKs for top commit:
ValuedMammal:
ACK 80bf744a706caf60f08a97cf49f02531239715cd.
oleonardolima:
cACK 80bf744a706caf60f08a97cf49f02531239715cd
Tree-SHA512: 0b1bacb0f3a57fd8c666e1ece14b9a733f9d5dfdec7efd6461b400d58ef0e302c286597531381e417b5fdf1b97659ed36266d2cf89f8a0c4cab5e4d9b3fdeed7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #181
We default to use
ringif multiple features are set, ensuring the features are additive. To that end, we also add a check to CI that asserts we succeed to build with both features set.Would be cool to get a patch release for this, as it's currently breaking our docs.rs builds in
lightning-liquidity.