Upgrade rustls to 0.23#132
Conversation
|
Version |
src/raw_client.rs
Outdated
|
|
||
| #[cfg(feature = "use-openssl")] | ||
| use openssl::ssl::{SslConnector, SslMethod, SslStream, SslVerifyMode}; | ||
| use rustls::pki_types::{Der, TrustAnchor}; |
There was a problem hiding this comment.
As seen from failing CI jobs, this must be gated
* With rustls 0.23 there is no longer a dependency on ring, allowing for easier compilation for various targets.
1eea0aa to
28b1aaa
Compare
|
Apologies for the substantial mess this caused! When making this PR it allowed some android target to build where I was having substantial trouble with ring. It has broken many other targets however and this was not readily apparent. I think in the future I should take more time to test across other targets? Big thanks for your work resolving this @thunderbiscuit |
|
Yeah ring has caused me problems in the past too with the Android NDK, so I totally understand. I don't think we could have predicted this, and certainly testing with all possible architecture would be insane. I'm puzzled by the decision in rustls to straight replace the default provider for something that doesn't build everywhere, but then again their docs (aws-lc-rs and co.) are very good and should in theory allow us to build for all platforms; it's just been harder than advertised IMO 😆. |
4dd7e21 Bump version to 0.21.0 and update CHANGELOG.md (Steve Myers) Pull request description: Bumped crate version to 0.21.0 and added below to changelog: ## 0.21.0 - Add use-rustls-ring feature #135 - refactor: make validate_merkle_proof more efficient #134 - chore: set rust edition to 2021, fix clippy, add ci fmt and clippy checks #139 ## 0.20.0 - Upgrade rustls to 0.23 #132 - chore(deps): upgrade rust-bitcoin to 0.32.0 #133 - ci: add test with MSRV 1.63.0 #128 ACKs for top commit: oleonardolima: ACK 4dd7e21 ValuedMammal: ACK 4dd7e21 Tree-SHA512: 3fcec2fb437733eac235bccb1b9c8f6b706e7a713c71de85016adc93f7db128ca6eadb5e9d1d44df27f1b49cce139b222aa9c21343afcf25befdf80a47442e51
28b1aaa0c304c52eb98d13ddc4bcc9e066c515ce upgrade rustls to 0.23 (Nick Farrow)
Pull request description:
With rustls 0.23 there is no longer a dependency on ring, allowing easier compilation for various targets.
Not super confident with my updates to `ServerCertVerifier` and `Der` of certificates (is this being tested?), needs review.
ACKs for top commit:
notmandatory:
utACK 28b1aaa0c304c52eb98d13ddc4bcc9e066c515ce
Tree-SHA512: 6561c4d20d446d86ca7a6c04ddb5a8acb136756606c82ca00e9b4a1f0eb2a3b00120d6db475f14474a89ebaa2ad600208d51c777cb5aeed0dcf62335a84fee5a
With rustls 0.23 there is no longer a dependency on ring, allowing easier compilation for various targets.
Not super confident with my updates to
ServerCertVerifierandDerof certificates (is this being tested?), needs review.