Add utility to validate GetMerkleRes#122
Merged
notmandatory merged 3 commits intobitcoindevkit:masterfrom Dec 7, 2023
Merged
Conversation
.. as it's convenient.
e2bb14f to
8d02689
Compare
8d02689 to
02a3ae1
Compare
02a3ae1 to
37bbe65
Compare
... as retrieved via `transaction_get_merkle`.
37bbe65 to
54fd52d
Compare
notmandatory
approved these changes
Dec 7, 2023
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK 54fd52d
Thanks for the addition, it's a handy thing to have in this project.
5 tasks
radiant-smith-lk20
added a commit
to radiant-smith-lk20/rust-electrum-client
that referenced
this pull request
Dec 15, 2025
… `GetMerkleRes`
54fd52d898bd8cfd448a4d303f12c156a7a33201 Add test coverage for `validate_merkle_proof` (Elias Rohrer)
fe33e19bdabb5da627731c5ca94fac42e7a53882 Add utility for validating a Merkle inclusion proof (Elias Rohrer)
dd872d67147a2abcae63f4450770f0a0d95c45cb Make response types `Clone` (Elias Rohrer)
Pull request description:
I recently needed to validate a Merkle inclusion proof as retrieved via `transaction_get_merkle`.
As I figured it might be useful to other people, too, we add it here as a simple utility method.
ACKs for top commit:
notmandatory:
ACK 54fd52d898bd8cfd448a4d303f12c156a7a33201
Tree-SHA512: aac12160d5b91a011988f45013eb92924c2dfb244c1720e73dc5bcb731e69065c38e022502c756100d8ee6c9af06efa0de9bbfbb2b9e3c2e34d3223539206e1c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently needed to validate a Merkle inclusion proof as retrieved via
transaction_get_merkle.As I figured it might be useful to other people, too, we add it here as a simple utility method.