Upgrade bitcoin to v0.31#121
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Dec 7, 2023
Merged
Conversation
be333cf to
5a3439a
Compare
5a3439a to
ca56216
Compare
Member
|
This all looks good to me, I only have one small nit, can you change your commit message to indicate this updates bitcoin to 0.31.0, it currently says 0.31.0-rc1. |
Upgrade bitcoin dependency to `rust-bitcoin v0.31.0`: Allows us to remove the dependency on `bitcoin-private` because the `hex` stuff is exposed by `bitcoin` now.
ca56216 to
dd3c171
Compare
Contributor
Author
|
Of course, my bad. |
Contributor
Author
|
Force push is change of commit log only, no other changes. |
Contributor
Author
|
Have you got a release queued up already @notmandatory? Can you ping me, if you think of it, when it drops and I'll push on with the other upgrades. No stress, it just popped into my head. |
Member
|
I'll do a |
Member
|
can't see the |
Member
|
I was planning to merge #128 when I'm back home on Tues and then add the 0.19.0 tag. But if someone can get to it sooner please go ahead. |
radiant-smith-lk20
added a commit
to radiant-smith-lk20/rust-electrum-client
that referenced
this pull request
Dec 15, 2025
dd3c171a7aa8a90ff1095bd177261e73cb1f70ad Upgrade bitcoin (Tobin C. Harding)
Pull request description:
Upgrade bitcoin dependency to `rust-bitcoin v0.31.0-rc1`:
Allows us to remove the dependency on `bitcoin-private` because the `hex` stuff is exposed by `bitcoin` now.
ACKs for top commit:
notmandatory:
ACK dd3c171a7aa8a90ff1095bd177261e73cb1f70ad
Tree-SHA512: 9082d3c2136445230bb23669f83fed58c90d1baf28d35527fc3dea1d40c9d3bdebeddbc44b3bdbc8e79c9b701e09cb453c018af0bc4ac8bcd1c4a14d11c90e39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade bitcoin dependency to
rust-bitcoin v0.31.0-rc1:Allows us to remove the dependency on
bitcoin-privatebecause thehexstuff is exposed bybitcoinnow.EDIT: Post merge edite, the upgrade was to
v0.31.0not the rc1 release.