fix(selection): Improve handling of fallback locktime#43
Open
ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(selection): Improve handling of fallback locktime#43ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
6 tasks
f4c0020 to
d74993b
Compare
The fallback locktime was being chained onto the input locktimes causing a `LockTypeMismatch` error whenever a Block based fallback conflicted with a Time based input CLTV requirement. This is fixed so that the fallback is used if no inputs require an absolute timelock, or if the fallback is the same unit we use the maximum locktime value.
d74993b to
260a46c
Compare
Collaborator
Author
|
In the last push
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #24 which correctly implements the fallback locktime during PSBT creation, while enabling the fallback to contribute to the maximum accumulated locktime, provided that the lock type units are in agreement.
Notes to the Reviewers
Previously when setting the locktime of the transaction the fallback locktime was being chained onto the input locktimes causing a
LockTypeMismatcherror whenever a height-based fallback conflicted with a time-based input CLTV requirement. Since thePsbtParams::defaultdefines a fallback_locktime that is height based, this made the default fallback incompatible with a time based input requirement.This is fixed so that the fallback is only used if no inputs require an absolute timelock, or if the fallback is the same unit, then the maximum locktime value is used.
Added a test to check that the fallback is ignored if the lock type is incompatible.