Include fallback_locktime in locktime accumulation#24
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Nov 14, 2025
Merged
Conversation
c3b23d2 to
8326277
Compare
This allows the caller to specify an absolute locktime greater than may be required by a planned input. Adds a test `test_fallback_locktime` for testing the expected locktime when creating a PSBT from a `Selection` and `PsbtParams`.
8326277 to
de31798
Compare
aagbotemi
reviewed
Nov 11, 2025
Collaborator
aagbotemi
left a comment
There was a problem hiding this comment.
Thank you for working on the test. I like the table-driven test approach here, it makes the different scenarios clear. I ran the test and it's working as expected.
aagbotemi
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the caller to specify an absolute locktime greater than may be required by a planned input.