chore(ci): pin proptest to 1.8.0 on 1.75.0 MSRV#2075
Merged
oleonardolima merged 7 commits intobitcoindevkit:release/chain-0.23.xfrom Nov 22, 2025
Merged
Conversation
Collaborator
Author
|
I wasn't expecting all these dependencies needing to be pinned for the Also, let me know if you think all squashed down to a single commit would be better, I just need this to move forward with #2027. |
oleonardolima
added a commit
to oleonardolima/bdk
that referenced
this pull request
Nov 21, 2025
chore(ci): pin `proptest` to `1.8.0` on `1.75.0` MSRV chore(ci): pin `webpki-roots@1.0.4` instead of `1.0.3` chore(ci): pin `socke2@0.6.1` instead of `0.6.0` chore(ci): pin `quote` to `1.0.41` chore(ci): pin `syn` to `2.0.106` chore(ci): pin `openssl` to `0.10.73` chore(ci): pin `openssl-sys` to `0.9.109`
ValuedMammal
approved these changes
Nov 21, 2025
3 tasks
822ce5e
into
bitcoindevkit:release/chain-0.23.x
19 checks passed
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
proptestdependency is used inbdk_chain, it's already pinned to1.2.0on1.63.0MSRV, and wasn't a problem on the1.75.0MSRV. Recently, it also released a new version, bumping their MSRV, onproptest 1.9.0.It adds a new step to pin it to
1.8.0on the1.75.0MSRV CI step.edit: I also had to update the pinned version
webpki-roots@1.0.4andsocke2@0.6.1.Notes to the reviewers
It only applies to
release/chain-0.23.xbranch; the master is already on1.85.0MSRV, which is not affected.Changelog notice
Checklists
All Submissions: