fix(core) Checkpoint::drop memory leak#2056
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Oct 19, 2025
Merged
Conversation
2 tasks
548f1fa to
a3bbba8
Compare
1 task
a3bbba8 to
20f6844
Compare
20f6844 to
5516165
Compare
Fix memory leak bug in `CheckPoint::drop` by using `Arc::into_inner`. Fix `CPInner::drop` logic so that if `CPInner::block` becomes generic and is of a type that required `drop`, it does not leak memory. Add tests for memory leak + stack overflow when dropping `CheckPoint`.
5516165 to
0bd93da
Compare
Collaborator
Author
|
I've rebased it on top of master, so it should be ready to go. |
ValuedMammal
added a commit
to ValuedMammal/bdk
that referenced
this pull request
Jan 13, 2026
Previously, methods of `CheckPoint` were constrained by `D: Copy`, and this was to prevent a possible memory leak caused by the use of `mem::forget` in the Drop impl for `CheckPoint`. Since the memory leak concern has been addressed (bitcoindevkit#2056), we relax the constaint to `Clone` instead which permits instances of `CheckPoint<D>` where `D` is not necessarily a Copy type.
ValuedMammal
added a commit
to ValuedMammal/bdk
that referenced
this pull request
Jan 13, 2026
Previously, methods of `CheckPoint` were constrained by `D: Copy`, and this was to prevent a possible memory leak caused by the use of `mem::forget` in the Drop impl for `CheckPoint`. Since the memory leak concern has been addressed (bitcoindevkit#2056), we relax the constraint to `Clone` instead which permits instances of `CheckPoint<D>` where `D` is not necessarily a Copy type.
ValuedMammal
added a commit
to ValuedMammal/bdk
that referenced
this pull request
Jan 13, 2026
Previously, methods of `CheckPoint` were constrained by `D: Copy`, and this was to prevent a possible memory leak caused by the use of `mem::forget` in the Drop impl for `CheckPoint`. Since the memory leak concern has been addressed (bitcoindevkit#2056), we relax the constraint to `Clone` instead which permits instances of `CheckPoint<D>` where `D` is not necessarily a Copy type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #1997, depends on #2055
Description
Fix memory leak bug in CheckPoint::drop by using Arc::into_inner.
Add tests (from the old PR) for memory leak + stack overflow when dropping CheckPoint.
Notes to the reviewers
It should be merged after #2055.
Changelog notice
Checklists
All Submissions:
Bugfixes: