feat(chain,wallet)!: rm ConfirmationTime#1643
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Oct 24, 2024
Merged
feat(chain,wallet)!: rm ConfirmationTime#1643ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
ConfirmationTime#1643ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
Conversation
We rm `ConfirmationTime` because it is essentially the same thing as `ChainPosition<ConfirmationBlockTime>` without the block hash. We also impl `serde::Deserialize` and `serde::Serialize` for `ChainPosition`.
Contributor
|
ACK a3d4eef |
Member
|
@evanlinjin should we add this to the 1.0-beta milestone? It's a breaking change but looks straight forward and has two ACKs. |
Member
Author
|
@notmandatory I agree. I think this makes sense to be part of |
6 tasks
5 tasks
notmandatory
added a commit
that referenced
this pull request
Nov 12, 2024
b0dc3dd feat(wallet)!: make `seen_at` mandatory for `Wallet::apply_update_at` (志宇) 00c568d revert(wallet)!: rm `Wallet::unbroadcast_transactions` (志宇) 200a16d fix(wallet)!: delete method `insert_tx` (valued mammal) ab27884 test(wallet): improve usage of test utils (valued mammal) 9bdf4cb chore: fix imports (valued mammal) 28d8061 test(wallet): fix test descriptor getters (valued mammal) 3135e29 test(wallet): add helpers to `test_utils` (valued mammal) 823bb39 feat(wallet): add module `test_utils` (valued mammal) 297bd9a test(wallet): refactor helper `insert_anchor_from_conf` (valued mammal) Pull request description: Follow up to #1643, refactor `insert_anchor_from_conf` to just insert an anchor of type `ConfirmationBlockTime` ### Notes to the reviewers The PR introduces a public `test_utils` module and "test-utils" cargo feature that exposes common helpers such as `get_funded_wallet`. Credit to #1492 for inspiring that idea. Usage of test utilities is enhanced overall, and tests are less dependent on problematic APIs that may be removed in the future. ### Changelog notice - `bdk_wallet`: Added "test-utils" feature flag that exposes common helpers for testing and development - Removed methods `Wallet::insert_tx`, `Wallet::insert_checkpoint`, `Wallet::unbroadcast_transactions` ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing * [x] I've added docs for the new feature * [x] This pull request breaks the existing API Top commit has no ACKs. Tree-SHA512: 561757595c65b4531dbf8b81f44387af6ac60114ecca493693cd975188741b5ff7b75a0dcf1dafc9d5750566baad81c644e7463c3c412a8331ad73de29601016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ConfirmationTime, and favorsChainPosition<ConfirmationBlockTime>instead. The only difference between these two structures is thatChainPosition<ConfirmationBlockTime>contains an additionalBlockHash. Additionally,ConfirmationTimewas not used in many places. It was mainly for displaying information inbdk_wallet::Wallet.We also impl
serde::Deserializeandserde::SerializeforChainPosition.Notes to the reviewers
Changelog notice
bdk_chain::ConfirmationTime. UseChainPosition<ConfirmationBlockTime>in place.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing