Skip to content

Implement BIP 118 validation (SIGHASH_ANYPREVOUT)#56

Merged
ajtowns merged 8 commits intobitcoin-inquisition:27.xfrom
ajtowns:202404-inq27-apo
May 7, 2024
Merged

Implement BIP 118 validation (SIGHASH_ANYPREVOUT)#56
ajtowns merged 8 commits intobitcoin-inquisition:27.xfrom
ajtowns:202404-inq27-apo

Conversation

@ajtowns
Copy link

@ajtowns ajtowns commented May 2, 2024

Forward port from #34

@ajtowns ajtowns added this to the 27.x milestone May 2, 2024
@ajtowns ajtowns force-pushed the 202404-inq27-apo branch 2 times, most recently from d1c5874 to efbac17 Compare May 2, 2024 04:16
@ajtowns ajtowns added the bip118 label May 2, 2024
@ajtowns ajtowns force-pushed the 202404-inq27-apo branch from efbac17 to 1c6f718 Compare May 6, 2024 22:09
ajtowns and others added 8 commits May 7, 2024 20:07
Introduce `KeyVersion` in preparation for defining new behaviours via
BIP 342's "unknown public key type" upgrade mechanism.
… was conserved

This fuzz targets copied the SignatureHashSchnorr function for Bitcoin
Core 23.0 and checks the output of the APO-ready SignatureHashSchnorr
from this branch against it.

This is to make sure the behaviour of the function was not changed for
non ANYPREVOUT keys, which would make some previously valid signatures
invalid and, even worse, some previously invalid signatures valid.
@ajtowns ajtowns force-pushed the 202404-inq27-apo branch from 1c6f718 to cf1ed61 Compare May 7, 2024 10:13
@ajtowns ajtowns merged commit 011ad33 into bitcoin-inquisition:27.x May 7, 2024
arminsabouri pushed a commit to arminsabouri/bitcoin that referenced this pull request Nov 30, 2025
efb8ea04e4 Merge bitcoin-core/crc32c-subtree#8: Sync to upstream
4a7a05c48d Merge remote-tracking branch 'google/main' into bitcoin-fork
21fc8ef304 Fix typo (bitcoin-inquisition#59)
89f69843a1 Fix misspelled "Proccess" in comment
02e65f4fd3 Bump deps (bitcoin-inquisition#56)
b9d6e825a1 Fix Windows CI build. (bitcoin-inquisition#54)
bbbb93ab5d Switch CI to GitHub Actions (bitcoin-inquisition#55)
d46cd17d70 Add clangd cache directory to .gitignore.

git-subtree-dir: src/crc32c
git-subtree-split: efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants