Change bitcoin address in RPC help message #9865
Conversation
…eople don't accidentally send coins there (like I did).
|
Concept ACK. Hope you didn't lose a lot on this, it's not one of our addresses :( Implementation-nit: please define a constant for this. |
|
I think the address was first mentioned in #3184. |
| + HelpExampleCli("walletpassphrase", "\"mypassphrase\" 30") + | ||
| "\nCreate the signature\n" | ||
| + HelpExampleCli("signmessage", "\"1D1ZrZNe3JUo7ZycKEYQQiQAWd9y54F4XZ\" \"my message\"") + | ||
| + HelpExampleCli("signmessage", "\"1D1ZrZNe3JUo7ZycKEYQQiQAWd9y54F4XX\" \"my message\"") + |
There was a problem hiding this comment.
You could use DummyAddress(Params()) instead to get an invalid address.
There was a problem hiding this comment.
Interesting. Though, I wanted to make the minimal change possible (I changed one letter) to keep things simpler. Do you think calling another function is necessary for this? It would be confusing if the address changes on each run for example.
There was a problem hiding this comment.
I think this is a good fix for 0.14 actually.
We can consider a cleaner solution later.
|
What if someone is trying to learn something and uses one of the documentation addresses and gets "invalid address" and thinks something is wrong with their node/service? I think I prefer having a valid address in documentation for this reason. My proposal to fix it would be that it uses an address that is owned by the wallet in question (specifically marked for help output), if the node has a wallet. That way any command that a user tries running from the help output without understanding could actually do something. |
|
I strongly prefer using an invalid address here. You are not supposed to copy/paste the address, it can happen and it's better if it fails. Prevents a lot of panic "where did I just send to". Using an address from the current wallet is a fair suggestion, but many of these calls are not coupled to the wallet at all, and shouldn't be. |
|
yeah on further thought failing is clearly better, even if it confuses someone once. |
|
ACK 83ac719 |
83ac719 Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). (Marijn Stollenga) Tree-SHA512: ca1163466a149d567b97efbfcfa8fdfe2d474245b4dd5a1a92555b4e87f8e99df5fee4cd79ef1ce6a98db2337846af78f37c2e6b31d02008b11fa0e151ce6590
83ac719 Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). (Marijn Stollenga) Tree-SHA512: ca1163466a149d567b97efbfcfa8fdfe2d474245b4dd5a1a92555b4e87f8e99df5fee4cd79ef1ce6a98db2337846af78f37c2e6b31d02008b11fa0e151ce6590
83ac719 Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). (Marijn Stollenga) Tree-SHA512: ca1163466a149d567b97efbfcfa8fdfe2d474245b4dd5a1a92555b4e87f8e99df5fee4cd79ef1ce6a98db2337846af78f37c2e6b31d02008b11fa0e151ce6590
|
@marijnfs sje3000@gmail.com is the email address of the user who probably has your BTC. Rather sneaky change to put their address (which is being used!) into the code, IMHO. |
Change bitcoin address in RPC help message to an invalid address, so people don't accidentally send coins there (like I did).