Fix Issue #9775 (Check returned value of fopen) #9798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Feb 19, 2017
src/util.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
I removed the semicolon in the latest commit.
Member
|
Please also remove the trailing whitespace
…On Sun, Feb 19, 2017 at 4:21 PM, Kirit Thadaka ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/util.cpp
<#9798 (comment)>:
> @@ -164,7 +164,7 @@ class CInit
delete ppmutexOpenSSL[i];
OPENSSL_free(ppmutexOpenSSL);
}
-}
+};
I removed the semicolon in the latest commit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9798 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv1pBwoosVmQm6Mxe3bMV5gNbEUP6ks5reF3qgaJpZM4MFdXS>
.
|
Contributor
Author
|
Hey I just noticed this issue has been closed. Do we still need this fix? |
Member
|
This issue hasn't been closed, we still need it. There were just some comments. Looks good to me now. Could you squash to one commit? (e.g. follow https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
…open) 40f11f8 Fix for issue bitcoin#9775. Added check for open() returning a NULL pointer. (kirit93)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…open) 40f11f8 Fix for issue bitcoin#9775. Added check for open() returning a NULL pointer. (kirit93)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
…open) 40f11f8 Fix for issue bitcoin#9775. Added check for open() returning a NULL pointer. (kirit93)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure file is opened before writing string to file to avoid seg faults in case open() returns a NULL pointer.
Attempts to fix #9775