Avoid VLA in hash.h #9791
Merged
Avoid VLA in hash.h #9791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
|
utACK 5c8fd50 |
Member
Author
|
To clarify: my GCC does not consider this to be a VLA, but at least some Clang versions do. |
Member
|
Well I think this makes the code clearer too, so it's a win in any case. |
Member
laanwj
added a commit
that referenced
this pull request
Feb 19, 2017
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.