Skip to content

Avoid variable length arrays #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Feb 17, 2017
Merged

Avoid variable length arrays #9785

laanwj merged 2 commits into from
Feb 17, 2017

Conversation

@sipa
Copy link
Member

@sipa sipa commented Feb 17, 2017

This removes this warning in some G++ versions:

httprpc.cpp: In function ‘bool HTTPReq_JSONRPC(HTTPRequest*, const string&)’:
httprpc.cpp:150:13: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector]
 static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
             ^~~~~~~~~~~~~~~

@sipa sipa changed the title Make KEY_SIZE a compile-time constant Avoid variable length arrays Feb 17, 2017
@theuni
Copy link
Member

theuni commented Feb 17, 2017

utACK c801c82

@luke-jr
Copy link
Member

luke-jr commented Feb 17, 2017

utACK

@laanwj
Copy link
Member

laanwj commented Feb 17, 2017

utACK c801c82

@laanwj laanwj merged commit c801c82 into bitcoin:master Feb 17, 2017
laanwj added a commit that referenced this pull request Feb 17, 2017
@laanwj
Merge #9785: Avoid variable length arrays
df42bcd 
c801c82 Move BIP70_MAX_PAYMENTREQUEST_SIZE to header (Pieter Wuille)
914fad1 Make KEY_SIZE a compile-time constant (Pieter Wuille)
gmaxwell
gmaxwell reviewed Feb 17, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

laanwj pushed a commit that referenced this pull request Feb 17, 2017
@sipa @laanwj
Make KEY_SIZE a compile-time constant
f873564 
Github-Pull: #9785
Rebased-From: 914fad1
laanwj pushed a commit that referenced this pull request Feb 17, 2017
@sipa @laanwj
Move BIP70_MAX_PAYMENTREQUEST_SIZE to header
973e345 
Github-Pull: #9785
Rebased-From: c801c82
codablock pushed a commit to codablock/dash that referenced this pull request Jan 26, 2018
@laanwj @codablock
Merge bitcoin#9785: Avoid variable length arrays
5e59642 
c801c82 Move BIP70_MAX_PAYMENTREQUEST_SIZE to header (Pieter Wuille)
914fad1 Make KEY_SIZE a compile-time constant (Pieter Wuille)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 3, 2019
@sipa
Make KEY_SIZE a compile-time constant
d59e623 
Github-Pull: bitcoin#9785
Rebased-From: 914fad1
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#9785: Avoid variable length arrays
dcbbe91 
c801c82 Move BIP70_MAX_PAYMENTREQUEST_SIZE to header (Pieter Wuille)
914fad1 Make KEY_SIZE a compile-time constant (Pieter Wuille)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#9785: Avoid variable length arrays
ec1548a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gmaxwell gmaxwell gmaxwell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sipa @theuni @luke-jr @laanwj @gmaxwell