Allow non-power-of-2 signature cache sizes #9533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK. Great find! |
Member
|
Travis failure is in keypool.py, so seemingly unrelated. |
dcousens
reviewed
Jan 13, 2017
| (uint32_t)((hash_function.template operator()<4>(e) * (uint64_t)size) >> 32), | ||
| (uint32_t)((hash_function.template operator()<5>(e) * (uint64_t)size) >> 32), | ||
| (uint32_t)((hash_function.template operator()<6>(e) * (uint64_t)size) >> 32), | ||
| (uint32_t)((hash_function.template operator()<7>(e) * (uint64_t)size) >> 32)}}; |
Contributor
There was a problem hiding this comment.
maybe a small inline function/macro would be easier to read than this?
Contributor
|
utACK. |
Contributor
|
someone should make sure to benchmark this change. |
Contributor
|
Just dropping a note here to assist other reviewers that you should also verify that |
Member
Author
|
Anything needed here? |
Contributor
|
Maybe a benchmark? I'd previously done a simulation on division v.s. masking and didn't see a difference, so I'm sure that this is fine... |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Apr 3, 2017
7482781 Allow non-power-of-2 signature cache sizes (Pieter Wuille) Tree-SHA512: 5731c22b46c5ae81cf6d52000c28e39b243a47d96d91079942a5b5a10db214449217f71aa2195e18f8a3917cb206b04c75dc13e4522eb700a1dbf1819013ba22
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 20, 2019
7482781 Allow non-power-of-2 signature cache sizes (Pieter Wuille) Tree-SHA512: 5731c22b46c5ae81cf6d52000c28e39b243a47d96d91079942a5b5a10db214449217f71aa2195e18f8a3917cb206b04c75dc13e4522eb700a1dbf1819013ba22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the fast reduction from http://lemire.me/blog/2016/06/27/a-fast-alternative-to-the-modulo-reduction/ instead of a modulus operator to quickly compute (nearly) uniformly distributed values within range.