Clean up bctest.py and bitcoin-util-test.py #9069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK dd76c14?w= |
Member
Oh yes that was irking me, had to change editor settings all the time just for that file. utACK dd76c14 |
laanwj
reviewed
Nov 3, 2016
src/test/bitcoin-util-test.py
Outdated
Member
There was a problem hiding this comment.
I think this comment is wrong, too? It looks for --srcdir not --src.
maflcko
reviewed
Nov 3, 2016
src/test/bctest.py
Outdated
Member
There was a problem hiding this comment.
µNit: no need to mention what fmt can be, when it is mentioned in the code just a line below.
Contributor
Author
There was a problem hiding this comment.
µACK. Comment shortened.
- remove newlines - change tabs for spaces, to align with convention in other py files - add comments - add 'Bitcoin Core Developers' copyright notice
dd76c14 to
2b175d4
Compare
Contributor
Author
|
Nits addressed and commits squashed. |
Member
laanwj
added a commit
that referenced
this pull request
Nov 4, 2016
2b175d4 Clean up bctest.py and bitcoin-util-test.py (John Newbery)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
2b175d4 Clean up bctest.py and bitcoin-util-test.py (John Newbery)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
2b175d4 Clean up bctest.py and bitcoin-util-test.py (John Newbery)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
2b175d4 Clean up bctest.py and bitcoin-util-test.py (John Newbery)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Nov 9, 2020
bitcoin-util-test.py backports Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8829 - bitcoin/bitcoin#8830 - bitcoin/bitcoin#8836 - bitcoin/bitcoin#8881 - bitcoin/bitcoin#9032 - bitcoin/bitcoin#9023 - bitcoin/bitcoin#9069 - bitcoin/bitcoin#9945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for code churn, but I've updated almost all of the code in these files, so I thought I might as well tidy up the code: