[qa] nulldummy.py: Don't run unused code #8835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tested ACK fa156c6 Tests fully pass on FreeBSD with:
|
laanwj
added a commit
that referenced
this pull request
Sep 29, 2016
fa156c6 [qa] nulldummy: Don't run unused code (MarcoFalke)
Contributor
|
Sorry, I'm not familiar with the testing framework and just copy-and-pasted some codes from other tests |
Member
|
@jl2012 I didn't notice it either when I looked through it, this was a good catch by @MarcoFalke |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2016
Github-Pull: bitcoin#8835 Rebased-From: fa156c6
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 30, 2018
fa156c6 [qa] nulldummy: Don't run unused code (MarcoFalke)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
fa156c6 [qa] nulldummy: Don't run unused code (MarcoFalke)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
fa156c6 [qa] nulldummy: Don't run unused code (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nulldummy.py accidentally imports too much and executes unused code