Skip to content

Conversation

@sdaftuar
Copy link
Member

No description provided.

@maflcko maflcko added the Docs label Jul 19, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should not be discouraged (yet). Miners are encouraged to set blockmaxsize to 600000-750000 (the latter being the default).

@luke-jr
Copy link
Member

luke-jr commented Jul 19, 2016

This is missing any mention that miners should not produce blocks larger than 1 MB until the network is known to be capable of handling it. This is critical for miners to understand before BIP 141 activates.

@sipa
Copy link
Member

sipa commented Jul 20, 2016

@luke-jr Do you know of a way to formulate that in a measurable way? How are miners expected to judge "the network known to be capable of handling it"? Also, BIP 141 won't activate in the release these notes are for.

@luke-jr
Copy link
Member

luke-jr commented Jul 20, 2016

When most miners are comfortable shutting off centralised relay networks and removing explicit outside addnode/connect to their nodes, that seems a reasonable indication that the network is ready.

@sipa
Copy link
Member

sipa commented Jul 20, 2016 via email

@luke-jr
Copy link
Member

luke-jr commented Jul 20, 2016

Miners worked fine without centralised networks before. It's not like it's unreasonable.

@sipa
Copy link
Member

sipa commented Jul 21, 2016

@luke-jr What I think the right criterion is, is whether the additional propagation delay from a larger block size would not affect (or only in a negligable amount) the economics of running things like relay network, SPV mining, ... etc. And it may well be the case that compact blocks, better mempool logic, validation caching, ... bring us closer to that, as they make relay times less dependent on the block size, and more on validation time (for which block weight is probably a better measure, if UTXO growth is taken into account).

I don't think release notes are the place for this kind of discussion, though. Are you ok with just removing the language about discouraging/encouraging how people use these options, and simply state their existence?

Then we can see what effect the changes in the 0.13 release have on the network, and reassess whether any recommendations are needed in the first release that actually does a block size increase (through segwit)?

@sdaftuar sdaftuar force-pushed the release-notes-mining branch from 5972ac3 to 52a4158 Compare July 21, 2016 14:09
@sdaftuar
Copy link
Member Author

Updated to address comments.

I added a brief section on segwit to correct any confusion that somehow 0.13.0 supports segwit on mainnet. We should consider expanding that section to include more helpful notes on how to use 0.13.0 on testnet.

@luke-jr
Copy link
Member

luke-jr commented Jul 21, 2016

I'm fine with deferring any recommendations until segwit has been released for mainnet.

activation, these calculations would be expected to differ.

For optimal runtime performance, miners using this release should specify
`-blockmaxweight` on the command line, and not specify `-blockmaxsize`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest an alternative here? I think we should somehow convey that there is a performance penalty to using -blockmaxsize.

@laanwj
Copy link
Member

laanwj commented Jul 21, 2016

Thanks for writing this up @sdaftuar . Looks like a clear story, I'm just going to merge this, if anyone has suggested changes they can be made later.

@laanwj laanwj merged commit 52a4158 into bitcoin:0.13 Jul 21, 2016
laanwj added a commit that referenced this pull request Jul 21, 2016
52a4158 Add release notes for mining changes (Suhas Daftuar)
@sipa
Copy link
Member

sipa commented Jul 21, 2016

@luke-jr The default is still max 750 kB (incurring the likely small performance loss), and this release does not have any means of increasing above 1 MB. The release notes simply explain the code changes.

@luke-jr
Copy link
Member

luke-jr commented Jul 21, 2016

But the release notes as currently written give incentive to take blockmaxsize and convert to blockmaxweight which can potentially produce blocks up to 3 MB once segwit is deployed.

@sdaftuar sdaftuar mentioned this pull request Jul 21, 2016
5 tasks
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants