Skip to content

Conversation

@Altoidnerd
Copy link
Contributor

Obviously if a user hasn't ready run autogen.sh, ./configure returns file not found. Do the instructions seem to presume you have already built bitcoin? I don't think they do.

It's a small thing but beginners would have trouble.

@Altoidnerd Altoidnerd changed the title need autogen.sh to configure bdb update build-unix.md (build bdb). Need autogen.sh to configure bdb Sep 1, 2015
@jonasschnelli
Copy link
Contributor

At this point, probably most user had already run ./autogen.sh. But calling ./autogen.sh twice is non problematic and better twice than never.

ACK.

@Altoidnerd
Copy link
Contributor Author

This is also a more complicated section of the doc, so perhaps the presumption is of an advanced user.

It just depends on how you think of docs and their purpose. I always try to write them as if the reader is typing the commands without knowing why. A very good doc will get the job done in that case too.

@laanwj
Copy link
Member

laanwj commented Sep 1, 2015

It's just an illustration how to point bitcoin's configure at your own BDB - not a general description how to do the autotools configure process - that should have been described earlier, so it may be better to refer back
But no problem with this change...

@fanquake
Copy link
Member

fanquake commented Sep 2, 2015

ACK. Please squash your commits.

@paveljanik
Copy link
Contributor

ACK after squashing.

@Altoidnerd
Copy link
Contributor Author

sorry ... I tried

git rebase -i HEAD~2 
git push origin master --force

Do I have to resubmit the PR now?

@jonasschnelli
Copy link
Contributor

Please don't resubmit/re-create the PR.
Just use git rebase -i HEAD~2, pick (p) the older commit and squash (s) the newer commit, ... than force push again.

If a user hasn't ready run autogen.sh, configure doesn't yet exist.  Do the instructions seem to presume you have already built bitcoin?  I don't think they do.

Would stifle beginners.

Update build-unix.md
@Altoidnerd
Copy link
Contributor Author

@jonasschnelli very good thank you.

@laanwj laanwj merged commit 5b85126 into bitcoin:master Sep 3, 2015
laanwj added a commit that referenced this pull request Sep 3, 2015
5b85126 Update build-unix.md (Altoidnerd)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants