Change default nTxConfirmTarget to 2 #6126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have no strong opinion, so ACK from me. This is trivial change of a default. |
Member
|
I like this default change (I've complained about the default of 1 being too expensive before, and if that becomes worse...), utACK |
Member
|
Needs rebase. |
6f3879b to
4a38a50
Compare
Contributor
Author
|
rebased |
Member
There was a problem hiding this comment.
BTW, ideally we'd define a DEFAULT_TX_CONFIRM_TARGET constant analogous to DEFAULT_TRANSACTION_FEE, to avoid this value having to be kept synchronized across three places
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think picking this number is mostly bike-shedding, but if/when #5159 gets merged, then it's more likely that
estimateFee 1will occasionally give a very high estimate, so setting the default lower will prevent accidentally spending too much on fees. I don't think these high estimates are problematic but just indicate busy times when you actually need a very high fee to be reliably confirmed in the next block. Also it's almost impossible to have a priority that is high enough to get you confirmed in the next block, so this helps with sending free transactions as well. (Note the default remains 25 on the GUI)