Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Sep 12, 2014

No description provided.

@gavinandresen
Copy link
Contributor

ACK

@jgarzik
Copy link
Contributor

jgarzik commented Sep 12, 2014

ut ACK

@laanwj
Copy link
Member

laanwj commented Sep 12, 2014

ACK, with one nit: please a debug message when an exception happens. I think completely ignoring it is not a good idea for troubleshooting and such.

@sipa
Copy link
Member Author

sipa commented Sep 12, 2014

I was trying to avoid introducing any risk of causing another exception while writing a debug log message.

@sipa
Copy link
Member Author

sipa commented Sep 12, 2014

Moved the catch inside the if (fDebug), and made it print a debug message.

src/main.cpp Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message needs a \n at the end

@gavinandresen
Copy link
Contributor

reviewed-but-untested-but-don't-think-testing-is-necessary-ACK

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4903_efad808aaece74a0308a77e35ad35e845edb97f8/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@gmaxwell
Copy link
Contributor

I can test, have a reproduction already.

@laanwj
Copy link
Member

laanwj commented Sep 16, 2014

@gmaxwell That's great

@gmaxwell
Copy link
Contributor

Tests out fine, I see it log the unparsable reject message. ACK.

@sipa sipa merged commit efad808 into bitcoin:master Sep 16, 2014
sipa added a commit that referenced this pull request Sep 16, 2014
efad808 Avoid reject message feedback loops (Pieter Wuille)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants