-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Avoid reject message feedback loops #4903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ACK |
|
ut ACK |
|
ACK, with one nit: please a debug message when an exception happens. I think completely ignoring it is not a good idea for troubleshooting and such. |
|
I was trying to avoid introducing any risk of causing another exception while writing a debug log message. |
|
Moved the catch inside the if (fDebug), and made it print a debug message. |
src/main.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message needs a \n at the end
|
reviewed-but-untested-but-don't-think-testing-is-necessary-ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4903_efad808aaece74a0308a77e35ad35e845edb97f8/ for binaries and test log. |
|
I can test, have a reproduction already. |
|
@gmaxwell That's great |
|
Tests out fine, I see it log the unparsable reject message. ACK. |
efad808 Avoid reject message feedback loops (Pieter Wuille)
No description provided.