ci: use LLVM/Clang 22 in tidy job#34662
Merged
hebasto merged 4 commits intobitcoin:masterfrom Mar 3, 2026
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
commented
Feb 24, 2026
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Feb 24, 2026
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662
ryanofsky
reviewed
Feb 24, 2026
| client_connection.get(), /* destroy_connection= */ client_owns_connection); | ||
| if (client_owns_connection) { | ||
| client_connection.release(); | ||
| client_connection.release(); // NOLINT(bugprone-unused-return-value) |
Contributor
There was a problem hiding this comment.
In commit "f: libmultiprocess tidy errors" (5be6040)
Can this be changed to (void)client_connection.release(); to see if it fixes the tidy error? (void) should be a more typical way of indicating the return value is intentionally not used
Member
There was a problem hiding this comment.
Let me know if that works and I'll switch it over in bitcoin-core/libmultiprocess#244
Member
Author
There was a problem hiding this comment.
Looks like using (void) is fine here.
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Feb 24, 2026
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Feb 24, 2026
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662
Sjors
reviewed
Feb 24, 2026
5be6040 to
ddc1aaf
Compare
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Feb 25, 2026
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662 Co-authored-by: fanquake <fanquake@gmail.com>
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Feb 25, 2026
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662 Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
ryanofsky
added a commit
to bitcoin-core/libmultiprocess
that referenced
this pull request
Feb 25, 2026
16dfc36 ci: avoid bugprone-unused-return-value lint in test (Sjors Provoost) dacd5ed ci: suppress nontrivial-threadlocal lint in proxy.cpp (Sjors Provoost) Pull request description: Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662 ACKs for top commit: ryanofsky: Code review ACK 16dfc36, just switching to NOLINT to (void) since last Tree-SHA512: fca97015733b88422f895e7a193fe6700f45a1a12904fe5f8857367561d4e2393dc0598373f908b507e8149eb4e9633f797856ff841ea80fb3e924fe786dc70b
ddc1aaf to
5a56a10
Compare
This was referenced Feb 26, 2026
Otherwise this check will "pass", like: ```bash -- Detecting CXX compile features - done -- Found LLVM 21.1.8 -- Found clang-tidy: CLANG_TIDY_EXE-NOTFOUND -- Configuring done (0.5s) ```
```bash
15 | #warning The ClangTidyModuleRegistry.h header is deprecated and will be removed in LLVM 24. All of the symbols it used to define have been moved into ClangTidyModule.h.
| ^~~~~~~
[100%] Linking CXX shared module libbitcoin-tidy.so
```
Added -config-file as otherwise run-clang-tidy no-longer seemed able to find the config file.
Member
Author
|
Rebased now that #34422 is in. |
Member
|
lgtm ACK 5e35a90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed for moving to Clang 22 in the tidy job.