guix: use a temporary file over sponge, drop moreutils#34627
guix: use a temporary file over sponge, drop moreutils#34627sedited merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK, deletes a guix dependency |
Remove sponge (moreutils).
|
my Guix build output Host architecture: d2440958f4ce2cd625deed6d010d633bf1d34e19f00a4c775b7bdd1ae0011a84 guix-build-0e48b84c0578/output/aarch64-linux-gnu/SHA256SUMS.part
f6c1ed18ad544fe2329abd31955a5f600d563bdffbcb9688f6a9b067e833b838 guix-build-0e48b84c0578/output/aarch64-linux-gnu/bitcoin-0e48b84c0578-aarch64-linux-gnu-debug.tar.gz
05a03dc268cfad7dfad0e0b3ac48558d63f68e8ba1db33dc184c83d61016df1a guix-build-0e48b84c0578/output/aarch64-linux-gnu/bitcoin-0e48b84c0578-aarch64-linux-gnu.tar.gz
7818096433509d67da5f64092d92c6070840636b3287baeae8cf644f043bca72 guix-build-0e48b84c0578/output/arm-linux-gnueabihf/SHA256SUMS.part
90f3b6e63d01eae4e6db7e9776d4f43797abcc9aab91e32cfb7600f34f238d2a guix-build-0e48b84c0578/output/arm-linux-gnueabihf/bitcoin-0e48b84c0578-arm-linux-gnueabihf-debug.tar.gz
11d72ce781d974eaaf05dbfb398ac0ed1418f420a808dc166bb65684f0c5b5d7 guix-build-0e48b84c0578/output/arm-linux-gnueabihf/bitcoin-0e48b84c0578-arm-linux-gnueabihf.tar.gz
d3199f393e49c16583a132f44c16c4a2ab6f470d7a7a49840dc9fb208f6780ea guix-build-0e48b84c0578/output/arm64-apple-darwin/SHA256SUMS.part
9158a1fe2e104cd600db0fd5256a4db28049662156320ef0c05b484002da79f7 guix-build-0e48b84c0578/output/arm64-apple-darwin/bitcoin-0e48b84c0578-arm64-apple-darwin-codesigning.tar.gz
5a567ef3b68597de9a083441be6c81d4bf09d0e6fcfe73abde50b9ed44d8ab7b guix-build-0e48b84c0578/output/arm64-apple-darwin/bitcoin-0e48b84c0578-arm64-apple-darwin-unsigned.tar.gz
2f11cf373b2550a34e2ce939857524eaebaa4f2be4ccf3d4c93e26d1a2c35a13 guix-build-0e48b84c0578/output/arm64-apple-darwin/bitcoin-0e48b84c0578-arm64-apple-darwin-unsigned.zip
b48759a2b45338b995655ece346746221121d61869f0922bfa658323c194d396 guix-build-0e48b84c0578/output/dist-archive/bitcoin-0e48b84c0578.tar.gz
f753c656d5eecec36e35318ad7b6e9a7e4a69b25a96d308ad9ac66fbee39033e guix-build-0e48b84c0578/output/powerpc64-linux-gnu/SHA256SUMS.part
00c97a17f1221cdab7101a20bd288d0bf200fec79b391623c210e95531930efb guix-build-0e48b84c0578/output/powerpc64-linux-gnu/bitcoin-0e48b84c0578-powerpc64-linux-gnu-debug.tar.gz
d91ac90119dbac52c44caa6c4feb5ed0cc206750309e0e9c1afc0c4066063b29 guix-build-0e48b84c0578/output/powerpc64-linux-gnu/bitcoin-0e48b84c0578-powerpc64-linux-gnu.tar.gz
511f010e29d0df3eaccb6c941372ae2df375085985412f5633b58fe0655ee469 guix-build-0e48b84c0578/output/riscv64-linux-gnu/SHA256SUMS.part
0af95b121f144042966ed4d30a0b912dc8686974816849a52a2680ba243da60c guix-build-0e48b84c0578/output/riscv64-linux-gnu/bitcoin-0e48b84c0578-riscv64-linux-gnu-debug.tar.gz
323122d3ca3f361962eb4eafee3d31c07be9d9cf4637c47b771b77d0573dbd00 guix-build-0e48b84c0578/output/riscv64-linux-gnu/bitcoin-0e48b84c0578-riscv64-linux-gnu.tar.gz
799af3d141aa6a7ec1f1773070aadbb2647edab4d9d1cce9e6a68c10cad38d4a guix-build-0e48b84c0578/output/x86_64-apple-darwin/SHA256SUMS.part
993cfe06e4e57354c3023896b8b69446cba2ac8589f9428621d16f33cc85261d guix-build-0e48b84c0578/output/x86_64-apple-darwin/bitcoin-0e48b84c0578-x86_64-apple-darwin-codesigning.tar.gz
1be164bdac118144723e15ef5a9796cb49aa0c99bc6f145be1e5267dd998da3d guix-build-0e48b84c0578/output/x86_64-apple-darwin/bitcoin-0e48b84c0578-x86_64-apple-darwin-unsigned.tar.gz
67897cc392db13d54b3ef28846b0024f481d19c90c83d38702b5c54f1e6b8267 guix-build-0e48b84c0578/output/x86_64-apple-darwin/bitcoin-0e48b84c0578-x86_64-apple-darwin-unsigned.zip
b022811f0123e174756044651528f84e89ad10ca6b7771dd77992a3e13b1bc2c guix-build-0e48b84c0578/output/x86_64-linux-gnu/SHA256SUMS.part
5f22f62c18cc47f64edebc54c8b3ebe4169bc2fb2f8ab5139eb79e63d9174e96 guix-build-0e48b84c0578/output/x86_64-linux-gnu/bitcoin-0e48b84c0578-x86_64-linux-gnu-debug.tar.gz
10b7dfff3c3669f836277af0c292361ca6615b077b332a6ee76bb265c0437573 guix-build-0e48b84c0578/output/x86_64-linux-gnu/bitcoin-0e48b84c0578-x86_64-linux-gnu.tar.gz
6ab920eefab0a0067a6a32d8cea9348815eb742cffd4ee796583fb92923ac9b5 guix-build-0e48b84c0578/output/x86_64-w64-mingw32/SHA256SUMS.part
cdc361c8886982ca512812e1e41b2d469d177391f9e681bb8be2611c88336a8b guix-build-0e48b84c0578/output/x86_64-w64-mingw32/bitcoin-0e48b84c0578-win64-codesigning.tar.gz
e7325ead08c3b08a55d148c5c56b4ab22d6b643e79da8262db4ba76c7599bb80 guix-build-0e48b84c0578/output/x86_64-w64-mingw32/bitcoin-0e48b84c0578-win64-debug.zip
015b602896c98dc4eb145da01718cafac9a2bf22c5b32709ac63d7bc8ae484f6 guix-build-0e48b84c0578/output/x86_64-w64-mingw32/bitcoin-0e48b84c0578-win64-setup-unsigned.exe
77c3729ff4758b103a4a703bcb3fecdce26962f1162f0867e856a8437df6ec20 guix-build-0e48b84c0578/output/x86_64-w64-mingw32/bitcoin-0e48b84c0578-win64-unsigned.zip |
0e48b84 to
c86bce5
Compare
|
Guix Build (aarch64): b64267e6753d0db5bb8c3fa765937bc48dcb8449426aba9d45d15b4aa4e012db guix-build-c86bce597a3c/output/aarch64-linux-gnu/SHA256SUMS.part
628e7d2a325e3fa436f6f84ea666484221c5de20c9814338e4a98234f718a947 guix-build-c86bce597a3c/output/aarch64-linux-gnu/bitcoin-c86bce597a3c-aarch64-linux-gnu-debug.tar.gz
198392fbb5abd5738361c9a3565c92a4df6a8bd5b33f2c2a7b88814f6efe5ab8 guix-build-c86bce597a3c/output/aarch64-linux-gnu/bitcoin-c86bce597a3c-aarch64-linux-gnu.tar.gz
d984e7cda38b26b2db23f00e049c11419fb0dd29b570fba7d2adc5215ec98c2f guix-build-c86bce597a3c/output/arm-linux-gnueabihf/SHA256SUMS.part
6f8a96660e96a1773bf3ee146852e1f265563b39f4b63524ea85db3589b4364a guix-build-c86bce597a3c/output/arm-linux-gnueabihf/bitcoin-c86bce597a3c-arm-linux-gnueabihf-debug.tar.gz
afc100f716133ee7f225301a5d93ab73ccb612b3522888f94a17cb91c2ec8082 guix-build-c86bce597a3c/output/arm-linux-gnueabihf/bitcoin-c86bce597a3c-arm-linux-gnueabihf.tar.gz
df48e4f86901bb6c842e24b2e77f1834b7c3b1a9352d98d8262a55195ac6ab96 guix-build-c86bce597a3c/output/arm64-apple-darwin/SHA256SUMS.part
ae3bedcbe2de5388a488767a7e73fd0a970526585c821a173feb98a76bdb5d32 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-codesigning.tar.gz
9a927cb42b6a9bcbedab6773b52964fcb8c921b4c8a51ed04ff48d1dbfa12169 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-unsigned.tar.gz
25742d590133f3157fb653f96d85e14ae9112f0e14049d4c78f198a17f1be351 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-unsigned.zip
760b9dfe399b62cb710af188c3cf92a686ea260a3c139ed6b51dd94060760a6c guix-build-c86bce597a3c/output/dist-archive/bitcoin-c86bce597a3c.tar.gz
44709ea8c8d794547e63884841aabe140992fb2ffeaa6fff64ce77ed0125bc67 guix-build-c86bce597a3c/output/powerpc64-linux-gnu/SHA256SUMS.part
26bb7b072a64a9c43d83fdfed7a3281efc7b2e7a6a53ee2ce459af60480e1c2a guix-build-c86bce597a3c/output/powerpc64-linux-gnu/bitcoin-c86bce597a3c-powerpc64-linux-gnu-debug.tar.gz
dd32cce440b717d637b25963f95ef1086affef9d9f802ede6c45360365d4cb3a guix-build-c86bce597a3c/output/powerpc64-linux-gnu/bitcoin-c86bce597a3c-powerpc64-linux-gnu.tar.gz
9d0e253846649f5fccdd7981164f352fdf19d3f023f8fb30324cf257864ec559 guix-build-c86bce597a3c/output/riscv64-linux-gnu/SHA256SUMS.part
413651c05f4aedc8c8ec525548dd72c86e2402a8964708d1fd3a421937237573 guix-build-c86bce597a3c/output/riscv64-linux-gnu/bitcoin-c86bce597a3c-riscv64-linux-gnu-debug.tar.gz
e7a0ad9aae2a8c9f592856e48b405609ee7c46f65f598b4e6881bb986c5561c1 guix-build-c86bce597a3c/output/riscv64-linux-gnu/bitcoin-c86bce597a3c-riscv64-linux-gnu.tar.gz
daaa6e558c53957e82960bb916fc6c6adc4d673eb6e314a4241f716210a3124a guix-build-c86bce597a3c/output/x86_64-apple-darwin/SHA256SUMS.part
c027b203eb6f5178f4d59f5fc7d51433e337b225119bf6f7c24630f2e78a569c guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-codesigning.tar.gz
3b2f1b27a68a1f41f9af0e24e9f6352dafe01a98e1a634fe926645ac2eb565fa guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-unsigned.tar.gz
38e31edf31b29e7fa9d15bbeed527bf6d7e39b0e8bc61c52b44580ea875e3756 guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-unsigned.zip
3da5fd7b254671ae5feeedba244ef7e6d6adc84d3e239c0b2ef6589a3cef6433 guix-build-c86bce597a3c/output/x86_64-linux-gnu/SHA256SUMS.part
1ae50a43d801e4b403447c29000507f50a741698fedda46383cc937ae616c5a0 guix-build-c86bce597a3c/output/x86_64-linux-gnu/bitcoin-c86bce597a3c-x86_64-linux-gnu-debug.tar.gz
71f65ec6bdf8dd1b451205fef77120bf62191865d68a875aaa4c91c32019095a guix-build-c86bce597a3c/output/x86_64-linux-gnu/bitcoin-c86bce597a3c-x86_64-linux-gnu.tar.gz
d70b6a4be4d94bfe19e358426d7d3b536d2a007f61c0d4b3cdf45c050ee4fc27 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/SHA256SUMS.part
d55a3d0065614fd080aeac6f4e82950752cb4fcfb92239826db4d3333305e1e5 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-codesigning.tar.gz
7e394a3b54c82458a8ac7ac8f5dedcc79abca0474ff650f3daa896513fc903ad guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-debug.zip
5e85ee6e9936dcfbb3a1b55e59f331ec4bb1301943975e529006879041b8001d guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-setup-unsigned.exe
c6724c3a2e1a25daa2b710feeaa67efe4e32a875234c4a157cefa0eb5d62ae63 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-unsigned.zip |
|
crACK c86bce5 |
janb84
left a comment
There was a problem hiding this comment.
crACK c86bce5
Drops moreutils in favor of temp files, with the super small risk of some file system pollution on error. But this risk is negated because the file disappears when the Guix container exits. lgtm ! nice find.
Host architecture: aarch64
Commit: c86bce597a3c
b64267e6753d0db5bb8c3fa765937bc48dcb8449426aba9d45d15b4aa4e012db guix-build-c86bce597a3c/output/aarch64-linux-gnu/SHA256SUMS.part
628e7d2a325e3fa436f6f84ea666484221c5de20c9814338e4a98234f718a947 guix-build-c86bce597a3c/output/aarch64-linux-gnu/bitcoin-c86bce597a3c-aarch64-linux-gnu-debug.tar.gz
198392fbb5abd5738361c9a3565c92a4df6a8bd5b33f2c2a7b88814f6efe5ab8 guix-build-c86bce597a3c/output/aarch64-linux-gnu/bitcoin-c86bce597a3c-aarch64-linux-gnu.tar.gz
d984e7cda38b26b2db23f00e049c11419fb0dd29b570fba7d2adc5215ec98c2f guix-build-c86bce597a3c/output/arm-linux-gnueabihf/SHA256SUMS.part
6f8a96660e96a1773bf3ee146852e1f265563b39f4b63524ea85db3589b4364a guix-build-c86bce597a3c/output/arm-linux-gnueabihf/bitcoin-c86bce597a3c-arm-linux-gnueabihf-debug.tar.gz
afc100f716133ee7f225301a5d93ab73ccb612b3522888f94a17cb91c2ec8082 guix-build-c86bce597a3c/output/arm-linux-gnueabihf/bitcoin-c86bce597a3c-arm-linux-gnueabihf.tar.gz
df48e4f86901bb6c842e24b2e77f1834b7c3b1a9352d98d8262a55195ac6ab96 guix-build-c86bce597a3c/output/arm64-apple-darwin/SHA256SUMS.part
ae3bedcbe2de5388a488767a7e73fd0a970526585c821a173feb98a76bdb5d32 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-codesigning.tar.gz
9a927cb42b6a9bcbedab6773b52964fcb8c921b4c8a51ed04ff48d1dbfa12169 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-unsigned.tar.gz
25742d590133f3157fb653f96d85e14ae9112f0e14049d4c78f198a17f1be351 guix-build-c86bce597a3c/output/arm64-apple-darwin/bitcoin-c86bce597a3c-arm64-apple-darwin-unsigned.zip
760b9dfe399b62cb710af188c3cf92a686ea260a3c139ed6b51dd94060760a6c guix-build-c86bce597a3c/output/dist-archive/bitcoin-c86bce597a3c.tar.gz
44709ea8c8d794547e63884841aabe140992fb2ffeaa6fff64ce77ed0125bc67 guix-build-c86bce597a3c/output/powerpc64-linux-gnu/SHA256SUMS.part
26bb7b072a64a9c43d83fdfed7a3281efc7b2e7a6a53ee2ce459af60480e1c2a guix-build-c86bce597a3c/output/powerpc64-linux-gnu/bitcoin-c86bce597a3c-powerpc64-linux-gnu-debug.tar.gz
dd32cce440b717d637b25963f95ef1086affef9d9f802ede6c45360365d4cb3a guix-build-c86bce597a3c/output/powerpc64-linux-gnu/bitcoin-c86bce597a3c-powerpc64-linux-gnu.tar.gz
9d0e253846649f5fccdd7981164f352fdf19d3f023f8fb30324cf257864ec559 guix-build-c86bce597a3c/output/riscv64-linux-gnu/SHA256SUMS.part
413651c05f4aedc8c8ec525548dd72c86e2402a8964708d1fd3a421937237573 guix-build-c86bce597a3c/output/riscv64-linux-gnu/bitcoin-c86bce597a3c-riscv64-linux-gnu-debug.tar.gz
e7a0ad9aae2a8c9f592856e48b405609ee7c46f65f598b4e6881bb986c5561c1 guix-build-c86bce597a3c/output/riscv64-linux-gnu/bitcoin-c86bce597a3c-riscv64-linux-gnu.tar.gz
daaa6e558c53957e82960bb916fc6c6adc4d673eb6e314a4241f716210a3124a guix-build-c86bce597a3c/output/x86_64-apple-darwin/SHA256SUMS.part
c027b203eb6f5178f4d59f5fc7d51433e337b225119bf6f7c24630f2e78a569c guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-codesigning.tar.gz
3b2f1b27a68a1f41f9af0e24e9f6352dafe01a98e1a634fe926645ac2eb565fa guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-unsigned.tar.gz
38e31edf31b29e7fa9d15bbeed527bf6d7e39b0e8bc61c52b44580ea875e3756 guix-build-c86bce597a3c/output/x86_64-apple-darwin/bitcoin-c86bce597a3c-x86_64-apple-darwin-unsigned.zip
3da5fd7b254671ae5feeedba244ef7e6d6adc84d3e239c0b2ef6589a3cef6433 guix-build-c86bce597a3c/output/x86_64-linux-gnu/SHA256SUMS.part
1ae50a43d801e4b403447c29000507f50a741698fedda46383cc937ae616c5a0 guix-build-c86bce597a3c/output/x86_64-linux-gnu/bitcoin-c86bce597a3c-x86_64-linux-gnu-debug.tar.gz
71f65ec6bdf8dd1b451205fef77120bf62191865d68a875aaa4c91c32019095a guix-build-c86bce597a3c/output/x86_64-linux-gnu/bitcoin-c86bce597a3c-x86_64-linux-gnu.tar.gz
d70b6a4be4d94bfe19e358426d7d3b536d2a007f61c0d4b3cdf45c050ee4fc27 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/SHA256SUMS.part
d55a3d0065614fd080aeac6f4e82950752cb4fcfb92239826db4d3333305e1e5 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-codesigning.tar.gz
7e394a3b54c82458a8ac7ac8f5dedcc79abca0474ff650f3daa896513fc903ad guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-debug.zip
5e85ee6e9936dcfbb3a1b55e59f331ec4bb1301943975e529006879041b8001d guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-setup-unsigned.exe
c6724c3a2e1a25daa2b710feeaa67efe4e32a875234c4a157cefa0eb5d62ae63 guix-build-c86bce597a3c/output/x86_64-w64-mingw32/bitcoin-c86bce597a3c-win64-unsigned.zip|
Guix build: |
Remove sponge (moreutils). Github-Pull: bitcoin#34627 Rebased-From: c86bce5
fdaf656 doc: update release notes for v30.x (fanquake) 0202ae3 doc: Update Guix install for Debian/Ubuntu (MarcoFalke) 2d035b1 guix: use a temporary file over sponge (fanquake) dca7700 test: valgrind --trace-children=yes for bitcoin wrapper (MarcoFalke) dd89249 test: Remove redundant warning about missing binaries (MarcoFalke) 6993b1b test: Fix broken --valgrind handling after bitcoin wrapper (MarcoFalke) d54d7df wallet: rpc: manpage: fix example missing `fee_rate` argument (SomberNight) 412725b net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures (ANAVHEOBA) 85f8d28 build: avoid exporting secp256k1 symbols (Cory Fields) b7a182c doc: fix broken bpftrace installation link (jayvaliya) 1a757af ci: Print verbose build error message in test-each-commit (MarcoFalke) f5d4dc9 ci: [refactor] Allow overwriting check option in run helper (MarcoFalke) 7317a0b ci: Always print low ccache hit rate notice (MarcoFalke) 0a768d4 fuzz: Use `__AFL_SHM_ID` for naming test directories (marcofleon) 48749cf miniscript: correct and_v() properties (Antoine Poinsot) 19b3e2e test: use ModuleNotFoundError in interface_ipc.py (fanquake) Pull request description: Backports: * #34409 * #34434 * #34445 * #34453 * #34461 * #34510 * #34549 * #34554 * #34561 * #34608 * #34627 * #34671 ACKs for top commit: willcl-ark: ACK fdaf656 marcofleon: lgtm ACK fdaf656 Tree-SHA512: dc0ca9a6298519e1dc69d37985f82d87765b6857b491285e3ff77eac5870bf72c662f18ab90b35d3df595dc75f9b0762299259e53588efb7f4994797fdd07213
Remove sponge (moreutils).