qa: Make wallet_multiwallet.py Windows crossbuild-compatible by hodlinator · Pull Request #34418 · bitcoin/bitcoin

hodlinator · 2026-01-27T12:35:18Z

Makes the functional test compatible with Linux->Windows cross-built executables.

Main parts:

Commit "qa: Check for platform-independent part of error message" switches to match on platform-independent part of error message.
Commit "qa: Test scanning errors individually" disentangles code causing the same error message substring, based on qa: Fix wallet_multiwallet.py #31410.
Commit "qa: Disable parts of the test when running under Windows or root" enables the test to be run on Windows, based in part on qa: Fix wallet_multiwallet.py #31410 (comment).

Also:

Removes unused option in wallet_multiwallet.py.
Breaks apart wallet_multiwallet.py's run_test() into smaller test functions.
Improves assert_equal() output for dicts.

Fixes #31409.

DrahtBot · 2026-01-27T12:35:28Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34418.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	janb84, w0xlt, achow101
Concept ACK	hebasto

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34603 (wallet: Fix detection of symlinks on Windows by achow101)
#34544 (wallet: Disallow wallet names that are paths including .. and . elements by achow101)
#34439 (qa: Drop recursive deletes from test code, add lint checks. by davidgumberg)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto

Concept ACK.

Thanks for taking this over!

w0xlt

Approach ACK. I’ll review it more closely soon.

test/functional/test_framework/util.py

janb84

~~ACK 596752a~~

EDIT: I made the wrong judgement on the difference in loggin (seeing more tests) as enough proof that the PR is an improvement next to an code-review. Will re-vist this PR.

This PR makes wallet_multiwallet.py Windows-compatible. Tested it on windows 11, msvc build (vs 2022)

this PR

2026-02-06T10:25:48.016394Z TestFramework (INFO): PRNG seed is: 3924437959039469419
2026-02-06T10:25:48.049997Z TestFramework (INFO): Initializing test directory C:\Users\user\AppData\Local\Temp\bitcoin_func_test_nylizqfb
2026-02-06T10:25:48.550233Z TestFramework (WARNING): Skipping chmod+symlink checks on Windows: chmod works differently due to how access rights work and symlink behavior with regard to the standard library is non-standard on cross-built binaries.
2026-02-06T10:25:48.756512Z TestFramework (INFO): Test mixed wallets
2026-02-06T10:25:49.850237Z TestFramework (INFO): Test initialization
2026-02-06T10:25:52.819255Z TestFramework (INFO): Test balances and fees
2026-02-06T10:25:54.266821Z TestFramework (INFO): Check for per-wallet settxfee call
2026-02-06T10:25:54.270096Z TestFramework (INFO): Test dynamic wallet loading
2026-02-06T10:25:54.748885Z TestFramework (INFO): Load first wallet
2026-02-06T10:25:54.760269Z TestFramework (INFO): Load second wallet
2026-02-06T10:25:54.769925Z TestFramework (INFO): Concurrent wallet loading
2026-02-06T10:25:54.803331Z TestFramework (INFO): Load remaining wallets
2026-02-06T10:25:54.856230Z TestFramework (INFO): Test dynamic wallet creation
2026-02-06T10:25:54.929120Z TestFramework (INFO): Test dynamic wallet unloading
2026-02-06T10:25:56.604190Z TestFramework (INFO): Test wallet backup and restore
2026-02-06T10:25:57.908829Z TestFramework (INFO): Test wallet lock file is closed
2026-02-06T10:25:58.309178Z TestFramework (INFO): Stopping nodes
2026-02-06T10:25:58.464283Z TestFramework (INFO): Cleaning up C:\Users\user\AppData\Local\Temp\bitcoin_func_test_nylizqfb on exit
2026-02-06T10:25:58.464577Z TestFramework (INFO): Tests successful

Master

2026-02-06T10:44:32.520149Z TestFramework (INFO): PRNG seed is: 9079423242423824445
2026-02-06T10:44:32.557824Z TestFramework (INFO): Initializing test directory C:\Users\user\AppData\Local\Temp\bitcoin_func_test_3ac39i27
2026-02-06T10:44:33.134825Z TestFramework (INFO): Verify warning is emitted when failing to scan the wallets directory
2026-02-06T10:44:33.135065Z TestFramework (WARNING): Skipping test involving chmod as Windows does not support it.
2026-02-06T10:44:38.490235Z TestFramework (INFO): Check for per-wallet settxfee call
2026-02-06T10:44:38.492665Z TestFramework (INFO): Test dynamic wallet loading
2026-02-06T10:44:38.978126Z TestFramework (INFO): Load first wallet
2026-02-06T10:44:38.990162Z TestFramework (INFO): Load second wallet
2026-02-06T10:44:38.999576Z TestFramework (INFO): Concurrent wallet loading
2026-02-06T10:44:39.036463Z TestFramework (INFO): Load remaining wallets
2026-02-06T10:44:39.087449Z TestFramework (INFO): Test dynamic wallet creation.
2026-02-06T10:44:39.150340Z TestFramework (INFO): Test dynamic wallet unloading
2026-02-06T10:44:40.821876Z TestFramework (INFO): Test wallet backup
2026-02-06T10:44:42.673883Z TestFramework (INFO): Stopping nodes
2026-02-06T10:44:42.828266Z TestFramework (INFO): Cleaning up C:\Users\user\AppData\Local\Temp\bitcoin_func_test_3ac39i27 on exit
2026-02-06T10:44:42.828464Z TestFramework (INFO): Tests successful

Test also still works on nix-shell/aarch64

fanquake · 2026-02-06T11:59:11Z

test/functional/wallet_multiwallet.py

+        if platform.system() == 'Windows':
+            # Additional context:
+            # - chmod: Posix has one user per file while Windows has an ACL approach
+            # - symlinks: GCC 13 has FIXME notes for symlinks under Windows:


GCC 13 has FIXME notes for symlinks under Windows:

I wonder if this will change. The FIXME has existed since 2018, when std::filesystem support for Windows was first added: gcc-mirror/gcc@9534a5e.

Updated the comment to document that it's still the case in latest release instead:

bitcoin/test/functional/wallet_multiwallet.py

Lines 74 to 79 in 9a7b725

# Additional context:

# - symlinks: GCC releases up to 15.2.0 still have FIXME notes for symlinks under Windows:

# https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/src/filesystem/ops-common.h;h=304d5896d0269d68ceb1102331a2cc6aeec32591;hb=releases/gcc-15.2.0#l128

self.log.warning('Skipping chmod+symlink checks on Windows: '

'chmod works differently due to how access rights work and '

'symlink behavior with regard to the standard library is non-standard on cross-built binaries.')

Hopefully that's slightly better for maintainability.

Also dropped the comment about chmod as I don't think it really added anything relevant to this test beyond what the warning below already states.

hodlinator · 2026-02-07T10:31:49Z

Thanks for your review @janb84! At first I was astonished that the test succeeds for you on master. Then I realized that this PR actually makes the test work for Linux->Windows cross builds. Will make it clearer in the title/PR description.

DrahtBot · 2026-02-09T11:29:53Z

🚧 At least one of the CI tasks failed.
_{Task Alpine (musl): https://github.com/bitcoin/bitcoin/actions/runs/21820908595/job/62953694277}
_{LLM reason (✨ experimental): mptest timed out (Timeout) causing the CI failure.}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

janb84

ACK 9a7b725

I revisited the PR, now using a cross compilation build. Using gcc, the master branch functional test will indeed fail to run:

Master

Temporary test directory at C:\Users\user\AppData\Local\Temp/test_runner_₿_🏃_20260209_120146
Remaining jobs: [wallet_multiwallet.py, wallet_multiwallet.py --usecli]
1/2 - wallet_multiwallet.py failed, Duration: 4 s

stdout:
2026-02-09T11:01:50.077850Z TestFramework (INFO): PRNG seed is: 4370893628585504645
2026-02-09T11:01:50.136334Z TestFramework (INFO): Initializing test directory C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_1
2026-02-09T11:01:51.071252Z TestFramework (INFO): Verify warning is emitted when failing to scan the wallets directory
2026-02-09T11:01:51.071428Z TestFramework (WARNING): Skipping test involving chmod as Windows does not support it.
2026-02-09T11:01:54.529466Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_framework.py", line 142, in main
    self.run_test()
    ~~~~~~~~~~~~~^^
  File "C:\Users\user\bitcoin\build\/test/functional/wallet_multiwallet.py", line 150, in run_test
    with self.nodes[0].assert_debug_log(expected_msgs=["Error while scanning wallet dir"]):
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\Programs\Python\Python314\Lib\contextlib.py", line 148, in __exit__
    next(self.gen)
    ~~~~^^^^^^^^^^
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_node.py", line 584, in assert_debug_log
    self._raise_assertion_error(f'Expected message(s) {remaining_expected!s} '
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                f'not found in log:\n\n{join_log(log)}\n\n')
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_node.py", line 229, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message(s) ['Error while scanning wallet dir'] not found in log:

 - 2026-02-09T11:01:52.527937Z [http] [httpserver.cpp:307] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:59769
 - 2026-02-09T11:01:52.528211Z [httpworker.0] [rpc/request.cpp:243] [parse] [rpc] ThreadRPCServer method=listwalletdir user=__cookie__
 - 2026-02-09T11:01:52.623421Z [httpworker.0] [wallet/db.cpp:69] [ListDatabases] [warning] Error scanning directory entries under C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_1\node0\regtest\wallets: No such file or directory


2026-02-09T11:01:54.584969Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-02-09T11:01:54.585174Z TestFramework (WARNING): Not cleaning up dir C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_1
2026-02-09T11:01:54.585290Z TestFramework (ERROR): Test failed. Test logging available at C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_1/test_framework.log
2026-02-09T11:01:54.585616Z TestFramework (ERROR):
2026-02-09T11:01:54.586080Z TestFramework (ERROR): Hint: Call C:\Users\user\bitcoin\build\test\functional\combine_logs.py 'C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_1' to consolidate all logs
2026-02-09T11:01:54.586260Z TestFramework (ERROR):
2026-02-09T11:01:54.586372Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-02-09T11:01:54.586471Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2026-02-09T11:01:54.586540Z TestFramework (ERROR):


stderr:
[node 0] Cleaning up leftover process


Remaining jobs: [wallet_multiwallet.py --usecli]
2/2 - wallet_multiwallet.py --usecli failed, Duration: 6 s

stdout:
2026-02-09T11:01:50.088312Z TestFramework (INFO): PRNG seed is: 8248417181429283859
2026-02-09T11:01:50.138382Z TestFramework (INFO): Initializing test directory C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_0
2026-02-09T11:01:51.977816Z TestFramework (INFO): Verify warning is emitted when failing to scan the wallets directory
2026-02-09T11:01:51.978010Z TestFramework (WARNING): Skipping test involving chmod as Windows does not support it.
2026-02-09T11:01:55.794679Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_framework.py", line 142, in main
    self.run_test()
    ~~~~~~~~~~~~~^^
  File "C:\Users\user\bitcoin\build\/test/functional/wallet_multiwallet.py", line 150, in run_test
    with self.nodes[0].assert_debug_log(expected_msgs=["Error while scanning wallet dir"]):
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\Programs\Python\Python314\Lib\contextlib.py", line 148, in __exit__
    next(self.gen)
    ~~~~^^^^^^^^^^
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_node.py", line 584, in assert_debug_log
    self._raise_assertion_error(f'Expected message(s) {remaining_expected!s} '
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                f'not found in log:\n\n{join_log(log)}\n\n')
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\bitcoin\build\test\functional\test_framework\test_node.py", line 229, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message(s) ['Error while scanning wallet dir'] not found in log:

 - 2026-02-09T11:01:53.850291Z [http] [httpserver.cpp:307] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:59814
 - 2026-02-09T11:01:53.850472Z [httpworker.1] [rpc/request.cpp:243] [parse] [rpc] ThreadRPCServer method=listwalletdir user=__cookie__
 - 2026-02-09T11:01:53.936116Z [httpworker.1] [wallet/db.cpp:69] [ListDatabases] [warning] Error scanning directory entries under C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_0\node0\regtest\wallets: No such file or directory


2026-02-09T11:01:55.850081Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-02-09T11:01:55.850322Z TestFramework (WARNING): Not cleaning up dir C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_0
2026-02-09T11:01:55.850430Z TestFramework (ERROR): Test failed. Test logging available at C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_0/test_framework.log
2026-02-09T11:01:55.850616Z TestFramework (ERROR):
2026-02-09T11:01:55.851275Z TestFramework (ERROR): Hint: Call C:\Users\user\bitcoin\build\test\functional\combine_logs.py 'C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20260209_120146\wallet_multiwallet_0' to consolidate all logs
2026-02-09T11:01:55.851362Z TestFramework (ERROR):
2026-02-09T11:01:55.851432Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-02-09T11:01:55.851523Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2026-02-09T11:01:55.851626Z TestFramework (ERROR):


stderr:
[node 0] Cleaning up leftover process



TEST                           | STATUS    | DURATION

wallet_multiwallet.py          | ✖ Failed  | 4 s
wallet_multiwallet.py --usecli | ✖ Failed  | 6 s

ALL                            | ✖ Failed  | 10 s (accumulated)

Using the same cross compilation build, this PR fixes the functional test:

PR

python .\build\test\functional\test_runner.py wallet_multiwallet.py
Temporary test directory at C:\Users\user\AppData\Local\Temp/test_runner_₿_🏃_20260209_132101
Remaining jobs: [wallet_multiwallet.py, wallet_multiwallet.py --usecli]
1/2 - wallet_multiwallet.py passed, Duration: 14 s
Remaining jobs: [wallet_multiwallet.py --usecli]
2/2 - wallet_multiwallet.py --usecli passed, Duration: 24 s

TEST                           | STATUS    | DURATION

wallet_multiwallet.py          | ✓ Passed  | 14 s
wallet_multiwallet.py --usecli | ✓ Passed  | 24 s

ALL                            | ✓ Passed  | 38 s (accumulated)
Runtime: 24 s

hodlinator · 2026-02-13T20:29:24Z

Latest push resolves conflict with master where exclusion of wallet_multiwallet.py was moved from ci.yml to ci-windows-cross.py.

janb84

re ACK 022b6e7

test/functional/wallet_multiwallet.py

@gregwebs

@gregwebs bitcoin#32950 @ldenman bitcoin#34418 @casey bitcoin#34562 @eklitzke bitcoin#32150 @rion bitcoin#34549

@gregwebs

@gregwebs bitcoin#34610 @ldenman bitcoin#32950 @casey bitcoin#34418 @eklitzke bitcoin#34562 @rion bitcoin#32150

w0xlt

ACK 022b6e7

Last use was removed in 0d32d66.

-BEGIN VERIFY SCRIPT- sed --in-place 's/self\.nodes\[0\]/node/g; s/node \= node/node \= self\.nodes\[0\]/' ./test/functional/wallet_multiwallet.py -END VERIFY SCRIPT-

This prepares for later breaking apart of run_test(). Note that the "wallet" lambda was renamed to "get_wallet" since otherwise the Python interpreter emitted: "UnboundLocalError: cannot access local variable 'wallet' where it is not associated with a value"

Makes the functions broken out from run_test() in the next commit more cohesive.

On Windows one gets different exception messages depending on whether running a native build or cross build.

This change ensures that each condition potentially triggering the "Error while scanning" log message is tested independently, avoiding false positives. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

test_scanning_sub_dir(): - Remove try/finally - we don't need to clean up after a failed test (done in this commit to maintain indentation). Regarding symlinks: bitcoin#31410 (comment) Kept some symlink creation which didn't disrupt Windows cross builds to make for a smaller diff and less cumbersome code. There is some hope of eventually getting better symlink support via bitcoin#34603. Co-authored-by: Ava Chow <github@achow101.com>

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

hodlinator

Latest push resolves conflict with 331a527 / #32138.

test/functional/wallet_multiwallet.py

janb84

re ACK 111864a

w0xlt

reACK 111864a

achow101 · 2026-03-13T22:38:10Z

ACK 111864a

DrahtBot added the Tests label Jan 27, 2026

hodlinator mentioned this pull request Jan 27, 2026

qa: Fix wallet_multiwallet.py #31410

Closed

hodlinator changed the title ~~qa: Make wallet_multiwallet.py Windows-compatible~~ qa: Make wallet_multiwallet.py Windows-compatible Jan 27, 2026

hebasto reviewed Jan 27, 2026

View reviewed changes

w0xlt reviewed Jan 27, 2026

View reviewed changes

janb84 reviewed Feb 3, 2026

View reviewed changes

test/functional/test_framework/util.py Show resolved Hide resolved

janb84 reviewed Feb 6, 2026

View reviewed changes

DrahtBot requested review from hebasto and w0xlt February 6, 2026 10:46

fanquake reviewed Feb 6, 2026

View reviewed changes

hodlinator changed the title ~~qa: Make wallet_multiwallet.py Windows-compatible~~ qa: Make wallet_multiwallet.py Windows crossbuild-compatible Feb 7, 2026

hodlinator force-pushed the 2026/01/31409_fix branch from 596752a to 9a7b725 Compare February 9, 2026 10:12

DrahtBot added the CI failed label Feb 9, 2026

fanquake mentioned this pull request Feb 9, 2026

mptest hangs, when run in a loop #34014

Open

janb84 reviewed Feb 9, 2026

View reviewed changes

DrahtBot removed the CI failed label Feb 10, 2026

This was referenced Feb 12, 2026

ci: Add and use ci-windows-cross.py helper #34548

Merged

wallet: Disallow wallet names that are paths including .. and . elements #34544

Open

DrahtBot added the Needs rebase label Feb 13, 2026

hodlinator force-pushed the 2026/01/31409_fix branch from 9a7b725 to 022b6e7 Compare February 13, 2026 20:27

DrahtBot removed the Needs rebase label Feb 13, 2026

janb84 reviewed Feb 16, 2026

View reviewed changes

achow101 mentioned this pull request Feb 17, 2026

wallet: Fix detection of symlinks on Windows #34603

Draft

w0xlt reviewed Feb 18, 2026

View reviewed changes

test/functional/wallet_multiwallet.py Show resolved Hide resolved

DrahtBot requested a review from w0xlt February 18, 2026 02:33

gniumg-source added a commit to gniumg-source/bitcoin that referenced this pull request Feb 18, 2026

README.md

a93cf6c

@gregwebs bitcoin#32950 @ldenman bitcoin#34418 @casey bitcoin#34562 @eklitzke bitcoin#32150 @rion bitcoin#34549

gniumg-source mentioned this pull request Feb 18, 2026

README.md #34610

Closed

gniumg-source added a commit to gniumg-source/bitcoin that referenced this pull request Feb 18, 2026

Contributing,md

e73f089

@gregwebs bitcoin#34610 @ldenman bitcoin#32950 @casey bitcoin#34418 @eklitzke bitcoin#34562 @rion bitcoin#32150

gniumg-source mentioned this pull request Feb 18, 2026

. #34611

Closed

w0xlt reviewed Feb 19, 2026

View reviewed changes

DrahtBot added the Needs rebase label Feb 19, 2026

hodlinator and others added 10 commits February 19, 2026 09:42

refactor(qa): Remove unused option

73cf858

Last use was removed in 0d32d66.

scripted-diff: self.nodes[0] => node

c811e47

-BEGIN VERIFY SCRIPT- sed --in-place 's/self\.nodes\[0\]/node/g; s/node \= node/node \= self\.nodes\[0\]/' ./test/functional/wallet_multiwallet.py -END VERIFY SCRIPT-

move-only(qa): Move wallet creation check down to others

bb1aff7

Makes the functions broken out from run_test() in the next commit more cohesive.

refactor(qa): Break apart ginormous run_test()

64a098a

qa: Check for platform-independent part of error message

ed43ce5

On Windows one gets different exception messages depending on whether running a native build or cross build.

qa: Test scanning errors individually

fb803e3

This change ensures that each condition potentially triggering the "Error while scanning" log message is tested independently, avoiding false positives. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

ci: Enable wallet_multiwallet.py in "Windows, test cross-built" job

c2e28d4

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

qa: Avoid duplicating output in case the diff is the same

111864a

hodlinator force-pushed the 2026/01/31409_fix branch from 022b6e7 to 111864a Compare February 19, 2026 08:55

hodlinator commented Feb 19, 2026

View reviewed changes

test/functional/wallet_multiwallet.py Show resolved Hide resolved

DrahtBot removed the Needs rebase label Feb 19, 2026

janb84 reviewed Feb 19, 2026

View reviewed changes

DrahtBot requested a review from w0xlt February 19, 2026 10:08

w0xlt reviewed Feb 19, 2026

View reviewed changes

DrahtBot requested a review from w0xlt February 19, 2026 23:58

achow101 merged commit 92a3d30 into bitcoin:master Mar 13, 2026
26 checks passed

	# Additional context:
	# - symlinks: GCC releases up to 15.2.0 still have FIXME notes for symlinks under Windows:
	# https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/src/filesystem/ops-common.h;h=304d5896d0269d68ceb1102331a2cc6aeec32591;hb=releases/gcc-15.2.0#l128
	self.log.warning('Skipping chmod+symlink checks on Windows: '
	'chmod works differently due to how access rights work and '
	'symlink behavior with regard to the standard library is non-standard on cross-built binaries.')

Conversation

hodlinator commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janb84 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fanquake Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

hodlinator Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

hodlinator commented Feb 7, 2026

Uh oh!

DrahtBot commented Feb 9, 2026

Uh oh!

janb84 left a comment

Choose a reason for hiding this comment

Uh oh!

hodlinator commented Feb 13, 2026

Uh oh!

janb84 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

Uh oh!

hodlinator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janb84 left a comment

Choose a reason for hiding this comment

Uh oh!

w0xlt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achow101 commented Mar 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hodlinator commented Jan 27, 2026 •

edited

Loading

DrahtBot commented Jan 27, 2026 •

edited

Loading

janb84 left a comment •

edited

Loading

w0xlt left a comment •

edited

Loading