net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures#34117
Closed
ANAVHEOBA wants to merge 2 commits intobitcoin:masterfrom
Closed
net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures#34117ANAVHEOBA wants to merge 2 commits intobitcoin:masterfrom
ANAVHEOBA wants to merge 2 commits intobitcoin:masterfrom
Conversation
Users running Bitcoin Core on home networks with routers that don't support PCP (Port Control Protocol) or NAT-PMP port mapping receive frequent warning-level log messages every few minutes: "pcp: Mapping failed with result NOT_AUTHORIZED (code 2)" This is expected behavior for many consumer routers that have PCP disabled by default, not an actionable error. The repeated warnings create unnecessary log noise. This change: - Adds explicit constants for NOT_AUTHORIZED result code (value 2) for both NAT-PMP and PCP protocols - Downgrades NOT_AUTHORIZED failures from LogWarning to LogDebug since this is an expected condition on many networks - Keeps LogWarning for other failure types that may indicate actual configuration or network issues The NOT_AUTHORIZED message will still be visible when running with -debug=net for users who need to troubleshoot port mapping issues. Fixes bitcoin#34114
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34117. ReviewsSee the guideline for information on the review process. |
When -externalip is specified, Bitcoin Core disables automatic address discovery by setting fDiscover to false. This is intended to prevent discovery of IPv4/IPv6 addresses when the user already knows their public IP. However, this also incorrectly prevented CJDNS addresses from being discovered and added to the local address list. CJDNS is a separate overlay network, and specifying an IPv4/IPv6 external IP should not affect CJDNS address advertising. This fix modifies: 1. Discover() - Continue processing CJDNS addresses even when fDiscover is false, skipping only non-CJDNS addresses 2. AddLocal() - Allow CJDNS addresses to be added even when discovery is disabled, since they should still be advertised Now users running with -externalip and -cjdnsreachable will have their CJDNS address properly appear in local addresses and be logged via AddLocal(), matching the behavior when -externalip is not specified. Fixes bitcoin#33471
Contributor
|
you have created a PR with 2 commits, one is unrelated to this PR it seems |
Contributor
Author
|
Both commit were on the issues list |
Contributor
Contributor
|
This PR mixes two unrelated changes:
These should be separate PRs. Each change looks reasonable on its own, but combining unrelated fixes makes review harder and complicates git history/bisecting. Would you please split this into two PRs and resubmit? |
Member
|
@ANAVHEOBA are you still working on this? |
Contributor
Author
|
Yes, I push today |
Contributor
Author
|
I am interested in working with bitcoin what is it going to take |
Member
|
I'll go ahead and close this for now. This clearly needs separate pull requests, so this one will need to be closed either way. |
Member
|
@ANAVHEOBA do you intend to open a new PR with the first commit only as a fix to #34114? If you don't want to then I'd be happy to cherry-pick your commit and open a pr with it in, as the fix looks good to me. |
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 22, 2026
…s by default Users running Bitcoin Core on home networks with routers that don't support PCP (Port Control Protocol) or NAT-PMP port mapping receive frequent warning-level log messages every few minutes: "pcp: Mapping failed with result NOT_AUTHORIZED (code 2)" This is expected behavior for many consumer routers that have PCP disabled by default. The repeated warnings create unnecessary log noise. This change: - Adds explicit constants for NOT_AUTHORIZED result code (value 2) for both NAT-PMP and PCP protocols - Downgrades NOT_AUTHORIZED failures from LogWarning to LogDebug after the first failure since this is an expected condition on many networks, UNLESS the user has explicitly enabled -natpmp - Keeps LogWarning for other failure types that may indicate actual configuration or network issues The NOT_AUTHORIZED message will still be visible when running with -debug=net for users who need to troubleshoot port mapping issues. Fixes bitcoin#34114 Inspired-by: 78e7259 (bitcoin#34117) Inspired-by-author: ANAVHEOBA <wisdomabraham92@gmail.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users running Bitcoin Core on home networks with routers that don't support PCP (Port Control Protocol) or NAT-PMP port mapping receive frequent warning-level log messages every few minutes:
"pcp: Mapping failed with result NOT_AUTHORIZED (code 2)"
This is expected behavior for many consumer routers that have PCP disabled by default, not an actionable error. The repeated warnings create unnecessary log noise.
This change:
The NOT_AUTHORIZED message will still be visible when running with -debug=net for users who need to troubleshoot port mapping issues.
Fixes #34114