build: add bitcoind-release preset with only BUILD_DAEMON enabled with release build type
#31730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with `release` build type When benchmarking IBD or reindex behavior we have to build bitcoind only, which currently looks like: cmake -B build -DCMAKE_BUILD_TYPE=Release -DBUILD_CLI=OFF -DBUILD_TESTS=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DENABLE_EXTERNAL_SIGNER=OFF -DENABLE_WALLET=OFF -DINSTALL_MAN=OFF After this change we can simplify that to cmake --preset bitcoind-release
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31730. ReviewsSee the guideline for information on the review process. |
Member
|
Seems easier to just call |
Contributor
Author
|
I can confirm that with git clean -fxd \
&& cmake -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_WALLET=OFF \
&& cmake --build build --target bitcoindproduces basically the same output during build phase as: git clean -fxd \
&& cmake -B build -DCMAKE_BUILD_TYPE=Release -DBUILD_CLI=OFF -DBUILD_TESTS=OFF -DBUILD_TX=OFF -DBUILD_UTIL=OFF -DENABLE_EXTERNAL_SIGNER=OFF -DENABLE_WALLET=OFF -DINSTALL_MAN=OFF \
&& cmake --build buildThanks! |
l0rinc
added a commit
to l0rinc/bitcoin
that referenced
this pull request
Jan 25, 2025
As documented in bitcoin#31730
l0rinc
added a commit
to bitcoin-dev-tools/benchcoin
that referenced
this pull request
Jan 25, 2025
As documented in bitcoin#31730
l0rinc
added a commit
to l0rinc/bitcoin
that referenced
this pull request
Jan 28, 2025
As documented in bitcoin#31730
l0rinc
added a commit
to bitcoin-dev-tools/benchcoin
that referenced
this pull request
Jan 28, 2025
As documented in bitcoin#31730
fanquake
added a commit
that referenced
this pull request
Feb 20, 2025
758a93d doc: update translation generation cmake example (Lőrinc) Pull request description: While investigating #31730 I noticed that * the `dev-mode` preset already contained [`-DWITH_BDB=ON`](https://github.com/bitcoin/bitcoin/blob/master/CMakePresets.json#L83) and [`-DBUILD_GUI=ON`](https://github.com/bitcoin/bitcoin/blob/master/CMakePresets.json#L70); * the preset already contained a [default binary dir](https://github.com/bitcoin/bitcoin/blob/master/CMakePresets.json#L64) which we could use; * the command only runs on my Mac if we disable `USDT`, and `MULTIPROCESS` and on Linux also without `MULTIPROCESS`. ACKs for top commit: hebasto: ACK 758a93d. Tree-SHA512: f5bef99bff090f53dae04018f17e60655698fea23084f6a3d38affd830ca041d5c56466633206b63ae01e85c55b784d003e323b2de7c59028b595d4e8f50783c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When benchmarking IBD or reindex behavior we have to build bitcoind only, which currently looks like:
After this change we can simplify that to
You can validate the change by comparing the outputs of before and after:
vs
which will only contain a single
CMAKE_BUILD_TYPE="Release"(butCMAKE_BUILD_TYPE ...................... Releaseshould be present in both)