build: remove old MSVC build system #30731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
reviewed
Aug 28, 2024
This has been superseded by CMake.
b544899 to
04fb085
Compare
hebasto
approved these changes
Aug 28, 2024
Member
|
There's a mention left in the top level gitignore: |
Member
|
Member
|
ACK 04fb085 |
vasild
approved these changes
Aug 28, 2024
Contributor
vasild
left a comment
There was a problem hiding this comment.
ACK 04fb085, except:
1: ad12ccc5d1 ! 1: 04fb085f6b build: Remove legacy MSVC build system
@@
## Metadata ##
-Author: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
+Author: fanquake <fanquake@gmail.com>
I already reviewed this at hebasto#166
fanquake
added a commit
that referenced
this pull request
Sep 2, 2024
faa382a ci, doc: Drop reference to `src/.bear-tidy-config` (Hennadii Stepanov) d71ac76 build: Remove Autotools-based build system (Hennadii Stepanov) e268b48 doc: Adjust `doc/design/libraries.md` (Hennadii Stepanov) d209e4f doc: Drop mentions of `share/genbuild.sh` (Hennadii Stepanov) Pull request description: This PR deletes the Autotools-based build system. The MSVC build system is deleted in #30731. ACKs for top commit: maflcko: re-ACK faa382a 🍦 TheCharlatan: ACK faa382a fanquake: ACK faa382a Tree-SHA512: 53df977b5b199a1c38f7f61a042a62b24831c559ba65a461b4ac1c96a1a56e2dfd676df79f1358fd1cc1749ff27e7b548086157f337d4f596c1054cb3d2d5739
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been superseded by CMake, and should not be blocked on anything for removal.