test: remove immediate tx relay workaround in wallet_groups.py #29822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts commit ab4efad (PR bitcoin#26970). This workaround is not needed anymore, as since bitcoin#27114 the test sets the noban permission for both in- and outbound connections via the `noban_tx_relay` setting, and we don't have to rely on these topology hacks anymore. See commit c985eb8.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
approved these changes
Apr 6, 2024
Member
|
lgtm ACK 93fae5a |
Pttn
added a commit
to RiecoinTeam/Riecoin
that referenced
this pull request
Apr 13, 2024
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 12, 2024
Summary: when `self.noban_tx_relay=True`, the following flag `-whitelist=noban,in,out@127.0.0.1`is added to `extra_args` to speed up tx relay/mempool sync. Before (all functional tests): ``` ALL | ✓ Passed | 1465 s (accumulated) Runtime: 163 s ``` After: ``` ALL | ✓ Passed | 1350 s (accumulated) Runtime: 150 s ``` This makes test duration shorter and hopefully solves some rare timeouts in interface_rest.py This concludes backport of [[bitcoin/bitcoin#27114 | core#27114]] bitcoin/bitcoin@c985eb8 Bypasses [[bitcoin/bitcoin#26970 | core#26970]] and [[bitcoin/bitcoin#29822 | core#29822]] Depends on D17114 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D17115
roqqit
pushed a commit
to doged-io/doged
that referenced
this pull request
Nov 21, 2024
Summary: when `self.noban_tx_relay=True`, the following flag `-whitelist=noban,in,out@127.0.0.1`is added to `extra_args` to speed up tx relay/mempool sync. Before (all functional tests): ``` ALL | ✓ Passed | 1465 s (accumulated) Runtime: 163 s ``` After: ``` ALL | ✓ Passed | 1350 s (accumulated) Runtime: 150 s ``` This makes test duration shorter and hopefully solves some rare timeouts in interface_rest.py This concludes backport of [[bitcoin/bitcoin#27114 | core#27114]] bitcoin/bitcoin@c985eb8 Bypasses [[bitcoin/bitcoin#26970 | core#26970]] and [[bitcoin/bitcoin#29822 | core#29822]] Depends on D17114 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D17115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts commit ab4efad (PR #26970). This workaround is not needed anymore, as since #27114 the test sets the noban permission for both in- and outbound connections via the
noban_tx_relaysetting, and we don't have to rely on this topology hack anymore. See commit c985eb8 (kudos to brunoerg!).Can be tested by executing
$ time ./test/functional/wallet_groups.pyboth on master and PR and verifying that the execution time is roughly equal.