test: refactor: deduplicate segwitv0 ECDSA signing for tx inputs #28154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
pinheadmz
reviewed
Aug 3, 2023
Comment on lines
+1675
to
+1677
| tx2.wit.vtxinwit.append(CTxInWitness()) | ||
| sign_input_segwitv0(tx2, 0, script, tx.vout[0].nValue, key) | ||
| signature = tx2.wit.vtxinwit[0].scriptWitness.stack.pop() |
Member
There was a problem hiding this comment.
I kinda feel like you don't need to use the helper for this one. It's actually +2 lines as opposed to -2 in the other locations.
Member
|
ACK 83d7cfd |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 25, 2023
…ng for tx inputs
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple follow-up for #28025. It introduces a
signing_input_segwitv0helper in order to deduplicate the following steps needed to create a segwitv0 ECDSA signature:SegwitV0SignatureHashwith the desired sighash type