Skip to content

Conversation

@pablomartin4btc
Copy link
Member

@pablomartin4btc pablomartin4btc commented Mar 7, 2023

References to utilstrencodings and lint-locale-dependence.sh where incorrect, updating them accordingly.

Also, adding another reference to util function LocaleIndependentAtoi, which is related with the updated section of the guide:

// LocaleIndependentAtoi is provided for backwards compatibility reasons.
//
// New code should use ToIntegral or the ParseInt* functions
// which provide parse error feedback.
//
// The goal of LocaleIndependentAtoi is to replicate the defined behaviour of
// std::atoi as it behaves under the "C" locale, and remove some undefined
// behavior. If the parsed value is bigger than the integer type's maximum
// value, or smaller than the integer type's minimum value, std::atoi has
// undefined behavior, while this function returns the maximum or minimum
// values, respectively.

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 7, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Mar 7, 2023
@pablomartin4btc pablomartin4btc changed the title doc: update broken links on developer-notes doc: update broken str util reference links on developer-notes Mar 7, 2023
@pablomartin4btc pablomartin4btc deleted the patch-1 branch March 8, 2023 20:48
@pablomartin4btc pablomartin4btc restored the patch-1 branch March 8, 2023 20:48
@pablomartin4btc pablomartin4btc deleted the patch-1 branch March 8, 2023 20:54
@pablomartin4btc pablomartin4btc restored the patch-1 branch March 8, 2023 20:54
@pablomartin4btc pablomartin4btc force-pushed the patch-1 branch 2 times, most recently from 1709a5b to bc6c303 Compare March 8, 2023 21:09
@maflcko
Copy link
Member

maflcko commented Mar 9, 2023

lgtm ACK da347de

@fanquake fanquake merged commit 3d53a85 into bitcoin:master Mar 11, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 12, 2023
…eveloper-notes

da347de doc: update broken links (pablomartin4btc)

Pull request description:

  References to `utilstrencodings` and `lint-locale-dependence.sh` where incorrect, updating them accordingly.

  Also, adding another reference to util function [`LocaleIndependentAtoi`](https://github.com/bitcoin/bitcoin/blob/master/src/util/strencodings.h#L108-L118), which is related with the updated section of the guide:

  ```
  // LocaleIndependentAtoi is provided for backwards compatibility reasons.
  //
  // New code should use ToIntegral or the ParseInt* functions
  // which provide parse error feedback.
  //
  // The goal of LocaleIndependentAtoi is to replicate the defined behaviour of
  // std::atoi as it behaves under the "C" locale, and remove some undefined
  // behavior. If the parsed value is bigger than the integer type's maximum
  // value, or smaller than the integer type's minimum value, std::atoi has
  // undefined behavior, while this function returns the maximum or minimum
  // values, respectively.
  ```

ACKs for top commit:
  MarcoFalke:
    lgtm ACK da347de

Tree-SHA512: c8f4cd9cff1fb3ea367ac9dbe5aa45dc187fc60114f2e2106e02e0e17fea4ee34d6e0c408fe920c2d8765e06b4dc30c231f0454fa35469c4399e0cadbcd341ba
@bitcoin bitcoin locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants