doc: DummySignInput mention external signer #27180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
glozow
reviewed
Mar 1, 2023
71c0bd2 to
6fc5f4f
Compare
Member
Member
Author
|
Not really I guess... |
Member
Contributor
|
ACK 6fc5f4f |
Contributor
|
ACK 6fc5f4f The comment is correct, CI failure is unrelated |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 8, 2023
6fc5f4f doc: DummySignInput mention external signer (Sjors Provoost) Pull request description: Followups for bitcoin#26032. So far nothing major. ACKs for top commit: ishaanam: ACK 6fc5f4f S3RK: ACK 6fc5f4f Tree-SHA512: e27edde9853487fe3eef8213f991aae3724f318bbbe0b11da23759879adaf9a31771e6ea0c30baaebca149032780b89b32aa540ff456ca3d5ec6adb0371749c6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups for #26032. So far nothing major.