Modernize rpcauth.py #27081
Modernize rpcauth.py #27081
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
tACK |
brunoerg
left a comment
There was a problem hiding this comment.
from CI (locally I got same error when running rpcauth-test):
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src/../test/util/rpcauth-test.py", line 33, in test_generate_password
base64.urlsafe_b64decode(password)).decode('utf-8')
File "/usr/lib/python3.10/base64.py", line 133, in urlsafe_b64decode
return b64decode(s)
File "/usr/lib/python3.10/base64.py", line 87, in b64decode
return binascii.a2b_base64(s)
binascii.Error: Incorrect paddingaf2e232 to
6aa646f
Compare
6aa646f to
e4e1790
Compare
|
Github ACK e4e1790 |
@codo1 If this comment can be helpful, your review is listed as ignored in #27081 (comment) and is not part of the merge commit because your ACK isn't followed by the commit hash. See these links for more information: |
Use Python3 constructions, and f-strings.