Skip to content

Conversation

@fanquake
Copy link
Member

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 20, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK instagibbs

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Additional include fixes are required to make the 23.x branch compile
using GCC 13.

Github-Pull: bitcoin#26921
Rebased-From: af86266
@instagibbs
Copy link
Member

ACK ea584a6

@fanquake
Copy link
Member Author

Going to merge this to unbreak building with GCC 13.x. i.e on rawhide.

@fanquake fanquake merged commit a896f61 into bitcoin:22.x Feb 16, 2023
@fanquake fanquake deleted the 22_2_backports branch February 16, 2023 15:43
ComputerCraftr pushed a commit to ComputerCraftr/XEP-Core that referenced this pull request Oct 29, 2023
ea584a617c6853eb1f9740600cd9db75d77948eb 23.x Add missing includes to fix gcc-13 compile error (fanquake)
c21e6a9ce210e0b0d1f4081ebd5dfefbe3c7af2d Add missing includes to fix gcc-13 compile error (MarcoFalke)

Pull request description:

  Backports:
  * bitcoin/bitcoin#26924

ACKs for top commit:
  instagibbs:
    ACK bitcoin/bitcoin@ea584a6

Tree-SHA512: e231d2e3e17f884eb9eb63f2f31829cef3e64351c9d6b90abeef421c366cef228a0a87b9c3a07c840879bd514ebe33b554fb62947c13bd05806865e59323cae7
ComputerCraftr pushed a commit to ElectraProtocol/OmniXEP-oldrepo that referenced this pull request Oct 29, 2023
ea584a6 23.x Add missing includes to fix gcc-13 compile error (fanquake)
c21e6a9 Add missing includes to fix gcc-13 compile error (MarcoFalke)

Pull request description:

  Backports:
  * bitcoin#26924

ACKs for top commit:
  instagibbs:
    ACK bitcoin@ea584a6

Tree-SHA512: e231d2e3e17f884eb9eb63f2f31829cef3e64351c9d6b90abeef421c366cef228a0a87b9c3a07c840879bd514ebe33b554fb62947c13bd05806865e59323cae7
@bitcoin bitcoin locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants