Skip to content

Conversation

@fanquake
Copy link
Member

This is JSON RPC related code that doesn't need to be in util, and should not be required by the kernel.

This is JSON RPC request code that doesn't need to be in util, and
should not be required by the kernel.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 17, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake
Copy link
Member Author

Guix Build:

6ba469c1a8862af7e9113ac1129cb81b78ca0f2c5cebde74d7c405fd21741eaf  guix-build-87a08cba43f8/output/aarch64-linux-gnu/SHA256SUMS.part
a7bc04e3019e8e234979ea5213b58d420d7753cfd3649ab13dda39cf9adfd491  guix-build-87a08cba43f8/output/aarch64-linux-gnu/bitcoin-87a08cba43f8-aarch64-linux-gnu-debug.tar.gz
23cdf73cfe982b155049c208d87d666d601e8b29636ba3f2c1c7d37d04ae863c  guix-build-87a08cba43f8/output/aarch64-linux-gnu/bitcoin-87a08cba43f8-aarch64-linux-gnu.tar.gz
1ea20d42602066777673fde0e3155cb445623f624df059e94ad17c94ad43344e  guix-build-87a08cba43f8/output/arm-linux-gnueabihf/SHA256SUMS.part
c1faa5eb352b121aecd08c62b6401a7e32940bbf8667fb839d8da5138621ce9b  guix-build-87a08cba43f8/output/arm-linux-gnueabihf/bitcoin-87a08cba43f8-arm-linux-gnueabihf-debug.tar.gz
01a06f2cb35e88020fb322b93a9e454a9ea3e9b2af3cb75294e96128e48859ad  guix-build-87a08cba43f8/output/arm-linux-gnueabihf/bitcoin-87a08cba43f8-arm-linux-gnueabihf.tar.gz
1d18c0a97ae3639f4f8e0311649c9e6ae8dfbca1dc68d1821ab1cfdd691206f0  guix-build-87a08cba43f8/output/arm64-apple-darwin/SHA256SUMS.part
48c55dc55000f7d930488c1ee802425c862b2cea50d89ed6cb729b81e28038a7  guix-build-87a08cba43f8/output/arm64-apple-darwin/bitcoin-87a08cba43f8-arm64-apple-darwin-unsigned.dmg
9ff10c8c0e84a1e352111685d26a1d7125f8d03eb4b58adab9280d3f700d14e3  guix-build-87a08cba43f8/output/arm64-apple-darwin/bitcoin-87a08cba43f8-arm64-apple-darwin-unsigned.tar.gz
a79494c1941a0ca2579ac740a92620cb5bf486574816eb8b11100ebc85069833  guix-build-87a08cba43f8/output/arm64-apple-darwin/bitcoin-87a08cba43f8-arm64-apple-darwin.tar.gz
572c228d4c7aa9c89f54d2e5bd32c0f3391a29a9312f769bdc9e6a752cd257f7  guix-build-87a08cba43f8/output/dist-archive/bitcoin-87a08cba43f8.tar.gz
d9ee48244ff6f95d29011789a959cb2ddae144d294562f779b430ca38deb447d  guix-build-87a08cba43f8/output/powerpc64-linux-gnu/SHA256SUMS.part
e8a4dbce02364cec2b3a3823576fe0fd8e52bba4b6cec2818be880339e1490dd  guix-build-87a08cba43f8/output/powerpc64-linux-gnu/bitcoin-87a08cba43f8-powerpc64-linux-gnu-debug.tar.gz
71d0e0419576b670b384a95e559266c1a1085b0bb97fe627484b1444652ef95e  guix-build-87a08cba43f8/output/powerpc64-linux-gnu/bitcoin-87a08cba43f8-powerpc64-linux-gnu.tar.gz
be0b23285bfc1e0225226729c520596ab53e79d9c2d49836580c03be6b8bdb81  guix-build-87a08cba43f8/output/powerpc64le-linux-gnu/SHA256SUMS.part
d71a08ac852703cd5266eda1cec0823621108bc255bd9c1f76e154be291a3709  guix-build-87a08cba43f8/output/powerpc64le-linux-gnu/bitcoin-87a08cba43f8-powerpc64le-linux-gnu-debug.tar.gz
2639370302ea81ff7b3b28facf4b69629bd9da24b3913ffd4575fefc44d0afb3  guix-build-87a08cba43f8/output/powerpc64le-linux-gnu/bitcoin-87a08cba43f8-powerpc64le-linux-gnu.tar.gz
4799408e111e848e160d77d6a0ba98bdb2c5e46606820be3e2b802d57ba352a0  guix-build-87a08cba43f8/output/riscv64-linux-gnu/SHA256SUMS.part
b66215601c5fe68092f9500f07cc43ba56f27f09167bf2a3fb0e3758656c79a8  guix-build-87a08cba43f8/output/riscv64-linux-gnu/bitcoin-87a08cba43f8-riscv64-linux-gnu-debug.tar.gz
7714afc79ee6c9c794f1e713238a2999c2c4b01a6cff0006824eb3cbd01da6ca  guix-build-87a08cba43f8/output/riscv64-linux-gnu/bitcoin-87a08cba43f8-riscv64-linux-gnu.tar.gz
e8bb0ed4f9b9abd5fb33f14863a5208a9d21ecccdac9015b070045c8a5996d85  guix-build-87a08cba43f8/output/x86_64-apple-darwin/SHA256SUMS.part
3121b3d67ad0e24290cb1c65e3785bcd89a880d4677a76f33693d976fdbc6a50  guix-build-87a08cba43f8/output/x86_64-apple-darwin/bitcoin-87a08cba43f8-x86_64-apple-darwin-unsigned.dmg
e29c6eca53b295fef07c84a1d7af8611db5d14a572eaa39e5899bd8679d0840e  guix-build-87a08cba43f8/output/x86_64-apple-darwin/bitcoin-87a08cba43f8-x86_64-apple-darwin-unsigned.tar.gz
849054a82d3aa0facce4d5a1a46649ac8198cb9c2c6205193662cacf5030efc1  guix-build-87a08cba43f8/output/x86_64-apple-darwin/bitcoin-87a08cba43f8-x86_64-apple-darwin.tar.gz
b81ca1abe213a212cd6211fb8d046e0e12c407c47476392eeaf6e85bd1222394  guix-build-87a08cba43f8/output/x86_64-linux-gnu/SHA256SUMS.part
f74147c7cd2aa20f37340c71829c5a5cf0ccb3f24fddf015f4f7c3b26997cd33  guix-build-87a08cba43f8/output/x86_64-linux-gnu/bitcoin-87a08cba43f8-x86_64-linux-gnu-debug.tar.gz
28fd5b9d395d6f90607eb91f4cc677ee27c2b636e307b84edde90b7cfabf6c31  guix-build-87a08cba43f8/output/x86_64-linux-gnu/bitcoin-87a08cba43f8-x86_64-linux-gnu.tar.gz
be5dcfb490c14dc810bf936b62dc0144bc28cfcd6caec01a7295baed5b9b7f30  guix-build-87a08cba43f8/output/x86_64-w64-mingw32/SHA256SUMS.part
de3fea65ee56e0ee56e7caa285908ffac04a58300cf344042b742ebb038b1248  guix-build-87a08cba43f8/output/x86_64-w64-mingw32/bitcoin-87a08cba43f8-win64-debug.zip
a0e4ab1bb59624d4cb9f9eadf3e21c320daf7a249779082ab0357cd223849631  guix-build-87a08cba43f8/output/x86_64-w64-mingw32/bitcoin-87a08cba43f8-win64-setup-unsigned.exe
c74f0c722ca43b06a01cd4e48d9ff21ee6ceb5be7c1df1c33d739214b657e38c  guix-build-87a08cba43f8/output/x86_64-w64-mingw32/bitcoin-87a08cba43f8-win64-unsigned.tar.gz
0ce4b7fb3fd0d681892ef52672e1a4a3011726450f7087774be9a6601df0a60b  guix-build-87a08cba43f8/output/x86_64-w64-mingw32/bitcoin-87a08cba43f8-win64.zip

Copy link
Contributor

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 87a08cb

@DrahtBot
Copy link
Contributor

Guix builds

File commit 635f190
(master)
commit 9c9717b966c3dbd08aeaea22a615b259631d0c4b
(master and this pull)
SHA256SUMS.part 3c9318cef0545624... fd4431c16822ae47...
*-aarch64-linux-gnu-debug.tar.gz 1d293f8fa4aa7e95... 1705abcfd809f925...
*-aarch64-linux-gnu.tar.gz 89f8101a24bc7045... ace160900e6a9198...
*-arm-linux-gnueabihf-debug.tar.gz cc40667d6ed9597a... e2c25857ec382e8b...
*-arm-linux-gnueabihf.tar.gz fdc82712af8a9005... c7bbedb83ee270d9...
*-arm64-apple-darwin-unsigned.dmg 5617f077002d9a92... f6f76cad3f7a601e...
*-arm64-apple-darwin-unsigned.tar.gz 485c4af0335ff134... fbb3832ca73f1192...
*-arm64-apple-darwin.tar.gz f6e3ea097c133612... c2021008caea9128...
*-powerpc64-linux-gnu-debug.tar.gz e2731051eb516242... 7eb22b5a6f0133a7...
*-powerpc64-linux-gnu.tar.gz 3b1d771ae42f70d5... 1e64c1712c13011c...
*-powerpc64le-linux-gnu-debug.tar.gz c17f3f66658a5a0d... fd61990ecca3386f...
*-powerpc64le-linux-gnu.tar.gz 40c6b28d196806ce... 51f0bbaff7bce32c...
*-riscv64-linux-gnu-debug.tar.gz 2a1a9566950d644c... 1ce04790a8fdf109...
*-riscv64-linux-gnu.tar.gz 54b020e75cb6f9d4... 1d23d87758f4d9f0...
*-win64-debug.zip 3ca8a7bb2a0d4e8e... 06a9f08da3578455...
*-win64-setup-unsigned.exe 3221971d81b9a61d... 8701436f0d19e170...
*-win64-unsigned.tar.gz aaa68f0ce8c42a9c... bcb3c02547b13528...
*-win64.zip 73bb8dc3d076b94b... 7c0b49f09b7faa27...
*-x86_64-apple-darwin-unsigned.dmg e7718aabb5ba7c3a... d76e0cedd35892da...
*-x86_64-apple-darwin-unsigned.tar.gz cfbb4248ea5c22d8... 9230e768569ec3d0...
*-x86_64-apple-darwin.tar.gz ff7d1c67b39561a4... 5e93877111c81e7b...
*-x86_64-linux-gnu-debug.tar.gz 491b7e93eac7ce9e... d56e76cfbc9a47ec...
*-x86_64-linux-gnu.tar.gz 26afd1a0dc6e8371... c2c209884f86bc22...
*.tar.gz 5a564c7456f10bb6... 5000144dcf71d7f9...
guix_build.log 268252a3201156b6... d43f22380c1fa53a...
guix_build.log.diff ae184f39ea8f353b...

@maflcko maflcko merged commit 52d6509 into bitcoin:master Jan 18, 2023
@fanquake fanquake deleted the move_rpc_request_out_util branch January 18, 2023 10:02
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 18, 2023
87a08cb build: move rpc/request from util lib to common (fanquake)

Pull request description:

  This is JSON RPC related code that doesn't need to be in util, and should not be required by the kernel.

ACKs for top commit:
  TheCharlatan:
    ACK 87a08cb

Tree-SHA512: 5f335be9f0f9ff02eff073af47558ecf505c1392c05f18ca24a065b12b8d92529ec3942d84978cc5028c38369c496ed0243653e1fa26d4db2fae26dfe55c3d65
@bitcoin bitcoin locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants