refactor: Make 64-bit shift explicit #26252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Also this change enables MSVC warning C4334 for all codebase. https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334
maflcko
approved these changes
Oct 5, 2022
Member
maflcko
left a comment
There was a problem hiding this comment.
ACK 5c5b85d 🚎
Show signature
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745 🚎
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjVnAv9FQwGec5u0nG1WliXrLEgomK9sscEUIZ30DPpvI2ILk0Rzz/jhwd8mu30
rj+KOPnedU705XpjhB5BJ57eihBXYQBkCBN6cV0jMs3GsfwKgZqmNMCH9rdDgEWB
HxDi+4TW862m9svCZBDdx7V4atS7/VdRX5yA9v1IFaydqF6JFFgHGE1wm/oVH3sv
Kci50Lf+iRJxwBb1ejG8kHqbH5Q0SlPTfPChL4YmXC+yd2jfNF4DFzgMfrYfI822
lOjN5oyTiYWKeXBAVp6taEnlP/DyIuFvgozhoT27j578IwviivxSERL9RGAo3zPA
HrdGYZqx1F8CxQ1EhzbJltIQeWowRinlnJZ7ATPs0Glb0eUkWJtNZn+wRVvSkmb3
b9xWM73kT/5ilbHWEpJFNMNaVDJOWvWS+DJQkudr6zoS26go4u6bcUthKVFYOtvu
F0f2CTDkSqBm8lbNLOMIYTGFLfP4Kih26xYU2Edq4ope5jvU6ICLVGSL5Y09XzxV
9y0qdut2
=/pMJ
-----END PGP SIGNATURE-----
jonatack
reviewed
Oct 5, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 5, 2022
5c5b85d refactor: Make 64-bit shift explicit (Hennadii Stepanov) Pull request description: [`std::array::at()`](https://en.cppreference.com/w/cpp/container/array/at) expects an argument of the `size_t` type. This PR avoids implicit type conversion (for both 64-bit and 32-bit systems). Also it enables MSVC warning [C4334](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334) for all codebase. ACKs for top commit: MarcoFalke: ACK 5c5b85d 🚎 jonatack: Code review ACK 5c5b85d Tree-SHA512: fda850a42068f2ada9f877fac9ff8af1e22b5dcb3e708f5b95c316e77c52c72d33cd9ec6507a7f5d1731d1afdf5af6dc65025d388cc480f82c46f4d88ef2d306
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::array::at()expects an argument of thesize_ttype. This PR avoids implicit type conversion (for both 64-bit and 32-bit systems).Also it enables MSVC warning C4334 for all codebase.