Skip to content

Conversation

@glozow
Copy link
Member

@glozow glozow commented Sep 16, 2022

There is no need to run this test twice with --descriptors and --legacy-wallet, as it doesn't use the wallet.

There is no need to run this test twice with --descriptors and
--legacy-wallet, as it doesn't ever use the wallet.
@fanquake fanquake added the Tests label Sep 16, 2022
@aureleoules
Copy link
Contributor

ACK 667401a.
Ran the test without the wallet compiled.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 667401a

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 667401a

@maflcko maflcko merged commit 9fefd00 into bitcoin:master Sep 16, 2022
@glozow glozow deleted the 2022-09-rbf-notwallet branch September 16, 2022 13:18
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 20, 2022
667401a [test] only run feature_rbf.py once (glozow)

Pull request description:

  There is no need to run this test twice with --descriptors and --legacy-wallet, as it doesn't use the wallet.

ACKs for top commit:
  aureleoules:
    ACK 667401a.
  theStack:
    ACK 667401a
  brunoerg:
    ACK 667401a

Tree-SHA512: 339213159fac29ebc5678461fae41645aed57877d5525e8ca4755890b869a17ae0bea3f590114769c84b71a7df20c59c9530ab8b327912151c82ec58022f7e71
@bitcoin bitcoin locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants