doc: remove incorrect mention of PR_GET_NAME #24740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the whole comment. These #include // For comments are near impossible to maintain, pollute diffs, and generally don't add a lot of value.
Contributor
|
LGTM ACK e8fc236 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2022
e8fc236 refactor: add missing std:: includes to threadnames.cpp (fanquake) 87f3c04 doc: remove incorrect mention of PR_GET_NAME (fanquake) Pull request description: By removing the whole comment. These `#include // For` comments are near impossible to maintain, pollute diffs, and generally don't add a lot of value. While here, also add the missing `std::` includes. ACKs for top commit: junderw: LGTM ACK e8fc236 Tree-SHA512: d29aff40c94f59c42f295a5738bc5ff2f4a2f2e6d270cc505f27d56d07d272597e2f8403d72fe45775661e1a1fc2af9fc52aeaeb41263bd3e9dfe255332383c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the whole comment. These
#include // Forcomments are near impossibleto maintain, pollute diffs, and generally don't add a lot of value.
While here, also add the missing
std::includes.