test: Add diamond-shape prioritisetransaction test #24623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebarton
reviewed
Mar 23, 2022
Contributor
jessebarton
left a comment
There was a problem hiding this comment.
Concept ACK fa58577
Test passed, no issues
I'm still learning quite a bit, so not sure what else to check for. Looking at the prioritisetransaction function and trying to understand the logic.
If reviews like this aren't helpful let me know.
fa58577 to
fa470b6
Compare
added 2 commits
March 24, 2022 14:33
* Add fallback for utxos_to_spend if none are provided * Refactor a for-loop
fa470b6 to
fa0758e
Compare
Member
Author
|
Rebased for minor rework |
Contributor
Member
Author
|
This probably can't catch #24364 in the current form. I'd suspect there will need to be at least one call to |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2022
fa0758e test: Add diamond-shape prioritisetransaction test (MarcoFalke) fa450c1 test: Rework create_self_transfer_multi (MarcoFalke) Pull request description: Looks like there is no test for diamonds, only for chains (in `mempool_packages.py`) ACKs for top commit: jamesob: ACK bitcoin@fa0758e Tree-SHA512: d261184a81df77d24fc256f58ad5ed4a13b7cd4e33f74c8b79495c761ff417817602d8e5d4f63f4bb1000ac63f89bbfa54d8d8994a7b2bb2e8a484c467330984
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is no test for diamonds, only for chains (in
mempool_packages.py)