Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 3, 2022

This is no-longer necessary after upstream libsecp256k1 changes that have been pulled into our repo.

This is no-longer necessary after upstream libsecp256k1 changes.
@fanquake fanquake added the Docs label Jan 3, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 3, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23470 (doc: consolidate legacy wallet documentation by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 62c173a

Running OpenBSD 7.0 here, I can confirm that passing CC_FOR_BUILD the the configure command is no longer needed.

@maflcko
Copy link
Member

maflcko commented Jan 4, 2022

For context, this reverts commit 01cd24c

Comment: #19605 (comment)

@maflcko maflcko merged commit ab788a4 into bitcoin:master Jan 4, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 4, 2022
62c173a doc: remove CC_FOR_BUILD from OpenBSD build doc (fanquake)

Pull request description:

  This is no-longer necessary after upstream libsecp256k1 changes that have been pulled into our repo.

ACKs for top commit:
  theStack:
    ACK 62c173a

Tree-SHA512: 7c328185afec366ff49096512b2fcc3c2f2a2381875f65f5444ffacf118f9a51e4e2237daaae6b32f742a7c4c54c1fbba7cee4e1807d7c4816123f6b0e7c33c8
@fanquake fanquake deleted the openbsd_no_longer_need_cc_for_build branch January 5, 2022 01:10
@bitcoin bitcoin locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants