Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Nov 15, 2021

It is hard to find a specific sanitizer task in less than a second. Fix that by mentioning the sanitizer first in the task name. Less useful information (with or without depends) follows the sanitizer.

Follow up to:

@katesalazar
Copy link
Contributor

I understood 'sanitizers' when I had to.
I would not have understood these 'Xsan' abbrevs.
NAK.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23504 (ci: Replace soon EOL hirsute with jammy by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member Author

maflcko commented Nov 16, 2021

I would not have understood these 'Xsan' abbrevs.

The goal of the task names is not to be a wikipedia. If you want to explore the details of the ci system further, you can read the scripts in the ./ci/ folder or refer to other resources.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa45922

@fanquake fanquake merged commit 7be37ee into bitcoin:master Nov 17, 2021
@maflcko maflcko deleted the 2111-ciTaskNames branch November 17, 2021 06:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 17, 2021
fa45922 ci: Rework ci task names (MarcoFalke)

Pull request description:

  It is hard to find a specific sanitizer task in less than a second. Fix that by mentioning the sanitizer first in the task name. Less useful information (with or without depends) follows the sanitizer.

  Follow up to:

  * bitcoin#20545
  * bitcoin#20572

ACKs for top commit:
  fanquake:
    ACK fa45922

Tree-SHA512: 87165caff4749cc415cef6ae36cac63fa448cec0a1c92cd6b691a0fbd22902466c8d861b0d922c3331e4bf36dbb4eba86d745ef135f391f7ff81461fe5159e05
@bitcoin bitcoin locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants