Skip to content

Conversation

@freewil
Copy link
Contributor

@freewil freewil commented Mar 7, 2013

This is a real simple change to make the comments match the property names of CRPCCommand

Here is the diff, ignoring the whitespace: https://github.com/bitcoin/bitcoin/pull/2348/files?w=1

@freewil freewil closed this Mar 7, 2013
@freewil freewil reopened this Mar 7, 2013
@luke-jr
Copy link
Member

luke-jr commented Mar 7, 2013

Suggest renaming "unlocked" at the same time, since it can be confused with wallet encryption lock/unlock.. "threadsafe"?

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dcf8b8fd9e9fc964eda083ee82e46df58958f705 for binaries and test log.

unlocked could be confused with wallet encryption
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/10ef3611697cdf867730689f6968ba48adc4d6e2 for binaries and test log.

gavinandresen added a commit that referenced this pull request Mar 11, 2013
make vRPCCommands comment match property names
@gavinandresen gavinandresen merged commit bd80c66 into bitcoin:master Mar 11, 2013
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
make vRPCCommands comment match property names
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants