build: fix python detection post #23182 #23317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23182 was broken. Fix up the changes, and add python3.11 as suggested.
Member
|
cr ACK a78137e |
hebasto
approved these changes
Oct 20, 2021
Member
hebasto
left a comment
There was a problem hiding this comment.
ACK a78137e, tested on Ubuntu Impish 21.10 running ./configure:
- master (0ccf9b2):
...
checking for python3.6... no
checking for python3.7... no
checking for python3.8... no
checking for python3.9,... no
checking for python3.10,... no
checking for python3... /usr/bin/python3
...
- this PR:
...
checking for python3.6... no
checking for python3.7... no
checking for python3.8... no
checking for python3.9... /usr/bin/python3.9
...
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 14, 2021
23182 was broken. Fix up the changes, and add python3.11 as suggested. Github-Pull: bitcoin#23317 Rebased-From: a78137e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23182 was broken. Fixup the changes, and add python3.11 as suggested. Was going to include this in other changes, but no point leaving this broken any longer.