ci: Add missed comments and test_bitcoin.exe command line option #22909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Sep 7, 2021
| QT_DOWNLOAD_HASH: 'b24436bbc49ac69d992efc148e640f02e8dec426bed5f8497abf735e7d7d59d0' | ||
| QT_LOCAL_PATH: 'C:\Qt5.12.11_x64_static_vs2019_160900' | ||
| IgnoreWarnIntDirInTempDetected: 'true' | ||
| merge_script: |
Member
There was a problem hiding this comment.
I am also wondering if the cpu can be reduced to 2 (The whole project only has 16 parallel Cirrus CPU, so it is more efficient to run more tasks in parallel with less CPU, and thus less idle CPU)
Member
Author
There was a problem hiding this comment.
Are CPUs for Windows containers separated from ones for Linux containers?
Member
Author
There was a problem hiding this comment.
Also msvc cannot use ccache, and brute CPU force seems pretty welcome here 🐅
Member
|
cr ACK 64015eb |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 7, 2021
…mand line option 64015eb ci: Add missed comments and test_bitcoin.exe command line option (Hennadii Stepanov) Pull request description: This PR is a bitcoin#21551 follow up, and it: - adds missed comments, see bitcoin#21551 (comment) - restores missed `-l test_suite` command line option for `test_bitcoin.exe`, see bitcoin#21551 (comment) ACKs for top commit: MarcoFalke: cr ACK 64015eb Tree-SHA512: ad1c91544da39a94f033bc55ae5fdaf5774475702edd026635389e68d20e2608cb599dd51f3c1412e0287beef073352e48d9ec005c94df38cfe4fe2d21a94fe3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a #21551 follow up, and it:
-l test_suitecommand line option fortest_bitcoin.exe, see ci: Move Windows MSVC build from AppVeyor to Cirrus #21551 (comment)