ci: Build and cache static Qt instead of downloading a pre-built one #22899
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK from me. I wouldn't be upset if I never need to build Qt again. 13 minutes is a very fast build time. Either the CirrusCI machine is extremely powerful or I have been doing something very wrong. Windows Qt builds have always taken me multiple hours. [Update: Probably because my Qt build was using |
f7a0b90 to
634c457
Compare
|
Rebased on top of #21551, and is ready for reviewing 🐅 |
|
utACK 3a68546. I've tested the Qt and subsequent Bitcoin Core builds work. I don't have a CirrusCI set up so haven't tested that. |
…ding a pre-built one 3a68546 ci: Build and cache static Qt instead of downloading a pre-built one (Hennadii Stepanov) Pull request description: This PR makes the MSVC build CI task free of [pre-built static Qt binaries](https://github.com/sipsorcery/qt_win_binary/releases). It uses the approach which is documented in bitcoin#22890. It takes about 13 minutes to build a static Qt dependency (for 8 CPUs):  with the maximum total time:  There is an additional benefit of this PR. It is no longer required to build a new static Qt package when a CI Windows image upgrades its building tools, and breaks the compatibility with the recent Qt package. ACKs for top commit: sipsorcery: utACK 3a68546. Tree-SHA512: 2cf358ccecb26293b52c04158d6d3366ae6257cc3c04262e02234f7d7a03086885c67f0aad5702fcaa6f035fe4a09967a81245c561614875ecd2e90e2e00bbaa
This PR makes the MSVC build CI task free of pre-built static Qt binaries. It uses the approach which is documented in #22890.
It takes about 13 minutes to build a static Qt dependency (for 8 CPUs):
with the maximum total time:
There is an additional benefit of this PR. It is no longer required to build a new static Qt package when a CI Windows image upgrades its building tools, and breaks the compatibility with the recent Qt package.