p2p: refactor: tidy up PeerManagerImpl::Misbehaving(...)
#22495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajarshimaitra
approved these changes
Jul 24, 2021
Contributor
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK 9459fe5
Agreed that the code looks cleaner than before.
Verified p2p_invalid_messages and p2p_filter test producing expected misbehavior.
jnewbery
reviewed
Jul 26, 2021
- introduce constant variables `score_before` and `score_after` in order to improve readability - deduplicate calls to LogPrint(), eliminates else-branch
9459fe5 to
8858e88
Compare
Contributor
Author
|
Force-pushed with the suggestions by jnewbery (#22495 (comment), #22495 (comment)). Thanks to all reviewers so far! |
Contributor
|
utACK 8858e88 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 28, 2021
…ving(...)` 8858e88 p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)` (Sebastian Falbesoner) Pull request description: This simple refactoring PR has the goal to improve the readability of the `Misbehaving` method by - introducing constant variables `score_before` and `score_now` (to avoid repeatedly calculating the former) - deduplicating calls to LogPrint(), eliminates else-branch ACKs for top commit: jnewbery: utACK 8858e88 rajarshimaitra: tACK bitcoin@8858e88 Tree-SHA512: 1d4dd5ac1d16ee9595edf4fa46e4960915a203641d74e6c33cffaba62ea71328834309a4451256fb45daf759f0cf6f4f199c46815afff6c89c0746e2ad4d4092
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple refactoring PR has the goal to improve the readability of the
Misbehavingmethod byscore_beforeandscore_now(to avoid repeatedly calculating the former)