util: improves error messages on get_previous_releases script #22442
Conversation
|
Concept ACK, will test later |
rajarshimaitra
left a comment
There was a problem hiding this comment.
Concept ACK with an error message comment.
179f1b4 to
e217dca
Compare
theStack
left a comment
There was a problem hiding this comment.
Left two possible improvements that came up while reviewing the code. Couldn't test yet (the machine I am using right now is running OpenBSD, where the script doesn't work; even if the platform is overrided to e.g. 'x86_64-linux-gnu', the tar command fails), but will do tomorrow on a Linux machine.
That sounds like something we should be able to fixup. |
If a requested version doesn't exist on our list of checksums it says it cannot do a checksum comparision instead of saying it did not match
e217dca to
179a051
Compare
theStack
left a comment
There was a problem hiding this comment.
tACK 179a051, tested on Debian bullseye/sid
master branch:
$ ./test/get_previous_releases.py -b v0.21.0
Releases directory: releases
Fetching: https://bitcoincore.org/bin/bitcoin-core-0.21.0/bitcoin-0.21.0-x86_64-linux-gnu.tar.gz
[ ... ]
Checksum did not match
$ echo $?
1
PR branch:
$ ./test/get_previous_releases.py -b v0.21.0
Releases directory: releases
Fetching: https://bitcoincore.org/bin/bitcoin-core-0.21.0/bitcoin-0.21.0-x86_64-linux-gnu.tar.gz
[ ... ]
Checksum for given version doesn't exist
$ echo $?
1
By the way, welcome as a new contributor NelsonGaldeman! 🎉
even if the platform is overrided to e.g. 'x86_64-linux-gnu', the tar command fails),
That sounds like something we should be able to fixup.
Yes, will take a look into that.
|
cr ACK 179a051 Warm welcome as a new contributor @NelsonGaldeman! 🥇 |
…leases script 179a051 util: improves error messages on get_previous_releases script (Nelson Galdeman) Pull request description: When previous releases are fetched and the specified version wasn't added to the checksum list we used to get a "Checksum did not match" which isn't true (bitcoin-core/bitcoincore.org#753 (comment)). If the specified version number is not on the list, it now logs cannot do the comparison instead. ACKs for top commit: practicalswift: cr ACK 179a051 theStack: tACK 179a051, tested on Debian bullseye/sid Tree-SHA512: 2a07ce75232f853fd311c43581f8faf12d423668946ae6ad784feece5b4d0edd57fc018ba1f0c5a73bfaccb326e0df9a643580d16bf427c1ec3ff34a9cdbc80c
When previous releases are fetched and the specified version wasn't added to the checksum list we used to get a "Checksum did not match" which isn't true (bitcoin-core/bitcoincore.org#753 (comment)).
If the specified version number is not on the list, it now logs cannot do the comparison instead.