Make IsSegWitOutput return true for taproot outputs #22421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Noticed by @roconnor-blockstream. |
Contributor
|
Concept ACK |
maflcko
approved these changes
Jul 10, 2021
src/script/sign.cpp
Outdated
Member
There was a problem hiding this comment.
nit: Maybe turn this into a switch-case to get compiler output when v2 is added, but this isn't updated?
Member
There was a problem hiding this comment.
@sipa Are you still working on this? Happy to take over if not.
Member
|
ACK, but I like @MarcoFalke's suggestion to make the compiler complain about an uncovered case in case more enum items are added in the future, and this function is not updated. |
|
Concept + review ACK e3e0594 |
e3e0594 to
8465978
Compare
Member
Author
|
I took another approach, and made it us |
achow101
reviewed
Jul 16, 2021
Member
|
Code Review ACK 8465978 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 23, 2021
8465978 Make IsSegWitOutput return true for taproot outputs (Pieter Wuille) Pull request description: This fixes a bug: currently `utxoupdatepsbt` will not fill in UTXO data for PSBTs spending taproot outputs. ACKs for top commit: achow101: Code Review ACK 8465978 jonatack: ACK 8465978 meshcollider: utACK 8465978 Tree-SHA512: 2f8f873450bef4b5a4ce5962a231297b386c6b1445e69ce5f36ab28eca7343be3a11bc09c38534b0f75e6f99ba15d78d3ba5d484f6c63e5a9775e1f3f55a74e0
roconnor-blockstream
added a commit
to ElementsProject/elements
that referenced
this pull request
Jul 25, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug: currently
utxoupdatepsbtwill not fill in UTXO data for PSBTs spending taproot outputs.