Skip to content

[TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System #22336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kiminuo wants to merge 6 commits into from
Closed

[TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System #22336

kiminuo wants to merge 6 commits into from

Conversation

@kiminuo
Copy link
Contributor

@kiminuo kiminuo commented Jun 24, 2021 •
edited
Loading

This PR is meant only to test some small modifications of #20744 to fix tests.

Android test failure:

fanquake and others added 6 commits June 24, 2021 18:42
@fanquake
build: set OSX_MIN_VERSION to 10.15
97e5377 
This is required to use std::filesystem on macOS.
@kiminuo @fanquake
refactor: replace boost::filesystem with std::filesystem
1e12e98 
Warning: Replacing fs::system_complete calls with fs::absolute calls
in this commit may cuase minor changes in behaviour because fs::absolute
no longer strips trailing slashes; however these changes are believed to
be safe.
@kiminuo @fanquake
build: remove boost::filesystem usage
d2aff72
@fanquake
build: remove Boost::system usage
9d29606
@fanquake
[NO MERGE] ci: use Debian Bullseye in ARM CI
bc035d6
@kiminuo
Use fs::canonical(p) and remove StripRedundantLastElementsOfPath …
17eff90 
…helper function.
@kiminuo kiminuo mentioned this pull request Jun 24, 2021
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 24, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Jun 25, 2021
Merged
Merged
Merged
Merged
Merged
Draft
Merged
@fanquake
Copy link
Member

fanquake commented Jul 16, 2021

As far as I'm aware, the relevant changes here have been integrated back into #22336. So I'm going to close this for now.

@fanquake fanquake closed this Jul 16, 2021
@kiminuo
Copy link
Contributor Author

kiminuo commented Jul 21, 2021

@fanquake The difference between this PR and your PR is in commit 17eff90 and consequently in checks:

I'm not sure whether your response means that you don't like the 17eff90 commit. Anyway, you did not explicitly reject it in this PR or in #20744 (comment). It would be helpful for me to know whether you like it or not.

@fanquake
Copy link
Member

fanquake commented Jul 21, 2021

The difference between this PR and your PR is in commit 17eff90

Apologies, I have the changes from 17eff90 integrated locally, but forgot to push the branch up. In future, if you want to suggest changes, just commenting is fine, there's not really a need to open these kinds of PRs. I'll rebase #20744 on top of the Android fixes for std::filesystem and push the changes up shortly.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Build system Scripts and tools Utils/log/libs Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiminuo @DrahtBot @fanquake