Minimal architectural changes necessary to support multiple wallets in bitcoin-qt #2220
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4af611676b784df41a9771792e828d62756c448d for binaries and test log. |
|
#2184 already implements dynamic loading and unloading of wallets. But in the interest of incremental commits that are easier to verify, I decided to open this new pull request with the idea of having a discussion on the UI design and merging in these changes first before attempting to merge in #2124 and #2184. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5bf2943a81e0937e4be0e8d2c6b4545b8d320cc4 for binaries and test log. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ea02ca6e44b089ecdd5395d0255857a1023914e3 for binaries and test log. |
|
Can you rebase this? Now that 0.8.0 final is out, I intend to test and merge it soon. |
|
@CodeShark I still plan to merge this as one of the next things, can you rebase please? |
|
I'm on it... |
|
Let me fix up some whitespace issues before you merge. |
|
Allright, laanwj, it's all yours :) |
|
Fix the commit message, please |
…n bitcoin-qt - This commit is a minimal restructuring necessary to support multiple wallets in the UI. Please see multiwallet-qt.txt for details.
|
The last rebase includes all current changes, i.e. the header and cpp cleanup pull? Then I'm fine with starting the evolution ^^. |
…2220) Conflicts: src/qt/bitcoingui.cpp
|
Merged (manually due to slight #include conflict that I introduced by merging another pull) |
|
@CodeShark Is it intended that bitcoingui.cpp and walletview.cpp seem to have quite much duplicate code in them? It would also be nice, if you could take a look at #2436. I created pulls for some other stuff that was not working, but perhaps there is more. We need to be really careful with such pulls IMHO. |
…itcoin#2220) Conflicts: src/qt/bitcoingui.cpp
- the send coins context menu entry was not working anymore, because a non current version of bitcoin#2220 was merged onto current master - also removes some unneeded spaces and adds a comment to WalletModel::getNumTransactions()
- fix debug window, by re-adding rpcConsole->setClientModel(clientModel); in BitcoinGUI::setClientModel(), which was removed by bitcoin#2220
This commit is a minimal restructuring necessary to support multiple wallets in the UI going forward. Please read https://github.com/CodeShark/bitcoin/blob/5bf2943a81e0937e4be0e8d2c6b4545b8d320cc4/multiwallet-qt.txt for details.