wallet: Avoid exception when loading with unsupported external signer #22168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@achow101 not sure its the best place to check for this, please advice. |
Member
|
This is definitely not the way. The correct way would be to check the flags at the beginning of loading and error out of the external signer is not supported. I'll make a PR. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 9, 2021
…n unsupported e60cd26 Do not load external signers wallets when unsupported (Andrew Chow) Pull request description: When external signer support is not compiled, do not load external signer wallets. Alternative to bitcoin#22168. ACKs for top commit: promag: Tested ACK e60cd26. meshcollider: Code review ACK e60cd26 Tree-SHA512: aed2d0038f448c2f89c6b48f412b106e63c9ed20e748e69aae21fb58c33fc7e4fa73375a52372c73788669eb2b968a8da6b022c65658fa4484f5bbcf205b1b15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the exception:
--enable-external-signerledger_nano_s--disable-external-signer-wallet=ledger_nano_sfails-nowalletand callingcli loadwallet ledger_nano_sfailsloadwalletafter the above gives "wallet already loaded"The exception is
std::out_of_rangefromstd::map::atraised byauto spk_man = m_spk_managers.at(id).get().Fix this by early checking for
ENABLE_EXTERNAL_SIGNER.